format_tests #53
Open
format_tests #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadatuta
requested changes
Mar 25, 2018
package.json
Outdated
| "eslint-config-pedant": "^0.8.0", | ||
| "mocha": "^3.1.0", | ||
| "rimraf": "^2.5.4" | ||
| "proxyquire": "^2.0.1", |
Member
There was a problem hiding this comment.
- "proxyquire": "^2.0.1",
- "sinon": "^4.4.8"| var isPiped = template instanceof stream.Readable, | ||
| content = (isPiped || typeof template === 'string') ? template : | ||
| template(entity, bemNaming(options.naming)), | ||
| var isPiped = content instanceof stream.Readable, |
Member
There was a problem hiding this comment.
useless
also try to use createTree for all
test/test1.js
Outdated
|
|
||
| function testEntityHelper(entities, levels, techs, options, expected) { | ||
| const actualPaths = prepareEntityData(entities, levels, techs, options) | ||
| .map(({ path }) => path) |
Member
There was a problem hiding this comment.
- .map(({ path }) => path)
+ .map(item => item.path)and remove eslint rule
| levelOptions.forceRewrite = options.forceRewrite; | ||
| } | ||
|
|
||
| return { |
Member
There was a problem hiding this comment.
most likely there's no need to tunnel all the fields here.
try to get it directly from global opts (maybe there's some common computation so it could be one more additional module).
deemidroll
force-pushed
the
format_tests
branch
from
9e33dc2 to
69fc5aa
Compare
deemidroll
force-pushed
the
format_tests
branch
from
69fc5aa to
503416a
Compare
dustyo-O
reviewed
May 17, 2018
| var levelsMap = config.levelMapSync(), | ||
| levelList = Object.keys(levelsMap); | ||
|
|
||
| var defaultLevels = levelList.filter(function(level) { |
There was a problem hiding this comment.
возможно, нужно вычислять только после levelByCwd, потому что на строке https://github.com/bem-tools/bem-tools-create/pull/53/files#diff-d854c73a37caf2bcd71fe93eba02959fR40 стоит справа от или
dustyo-O
reviewed
May 17, 2018
|
|
||
| var levelByCwd = levelList.filter(function(level) { | ||
| return cwd.indexOf(level) === 0; | ||
| }).sort().reverse()[0]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.