Support undocumented Github Actions values, and preserve roundtripping #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackKelly-Bellroy
approved these changes
Jul 21, 2025
Comment on lines
+57
to
+60
| data RunIf | ||
| = RunIfBool Bool | ||
| | RunIfString Text | ||
| deriving stock (Eq, Generic, Ord, Show) |
Member
There was a problem hiding this comment.
Possible future work: capture a proper AST here?
| -- | ||
| -- The type preserves the original format during round-trip serialization, | ||
| -- so numeric inputs remain numeric in the output YAML. | ||
| data UnstructuredValue |
Member
There was a problem hiding this comment.
Can GHA YAML use nulls here, and if so, should we represent them?
Member
Author
There was a problem hiding this comment.
Hrm hypothetically a null can be represented in the YAML, but I cannot think of any instance where having a null in a GHA workflow would be valid
There was a problem hiding this comment.
I wonder if ScalarValue would have been a more meaningful name here? "Unstructured" can mean different things to different people.
It's still debatable, of course, whether a Null value is "structured" or "scalar".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8