Skip to content

Conversation

@Jai0401
Copy link

@Jai0401 Jai0401 commented Apr 25, 2024

Fixes #366
Added Open API validator using https://github.com/IBM/openapi-validator

@Jai0401
Copy link
Author

Jai0401 commented Apr 25, 2024

@ravi-prakash-v Can you please review this PR?

@ravi-prakash-v
Copy link
Collaborator

@Jai0401 how to I test this? Can you add testing steps?

@ravi-prakash-v
Copy link
Collaborator

@Jai0401 could you please update your PR to validate the specification against Open API 3.1 specification? Refer to the latest release - version 1.1.1

@rajaneeshk90
Copy link
Collaborator

rajaneeshk90 commented Jan 15, 2025

Hi @Jai0401 ,

Thank you for submitting the PR.

I’ve provided my comments inline for your reference.

Additionally, here are a few points to consider:

  1. The workflow should also be triggered on the push events.
  2. We can include the paths subsection inside the push and pull_request sections.
  3. It’s a good idea to use the latest versions of these tools.
  4. The specification files are now using OpenAPI 3.1. We should validate the files against OpenAPI 3.1 in the lint steps. i.erun: openapi lint api/meta/build/meta.yaml step.

Thanks,
Rajaneesh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants