Skip to content

Conversation

@Vishalk91-4
Copy link

@Vishalk91-4 Vishalk91-4 commented Jan 24, 2024

@ravi-prakash-v
@emmayank
Fixes issue #366
Added OPEN API Valiator, not used swagger

Could you please review it

@ravi-prakash-v
Copy link
Collaborator

Hi @Vishalk91-4 can you also add testing steps to this? I'm unable to review this without Review Steps. Thanks

@rajaneeshk90
Copy link
Collaborator

Hi @Vishalk91-4,

Thank you for submitting the PR!

I’ve provided my comments inline for your reference. Please have a look.

Thanks,
Rajaneesh

@rajaneeshk90
Copy link
Collaborator

@Vishalk91-4

A few additional points to consider for the PR:

  1. The workflow should also be triggered on the draft branch.
  2. We can include the paths subsection inside the push section as well.
  3. It’s a good idea to use the latest versions of these tools.
  4. The specification files are now using OpenAPI 3.1. We should validate the files against OpenAPI 3.1 in the run: openapi lint api/meta/build/meta.yaml step.

Thanks,
Rajaneesh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants