-
Notifications
You must be signed in to change notification settings - Fork 1
correct the logic for participants' hire and ROS status #1141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chloe-yuu
wants to merge
38
commits into
dev-env
Choose a base branch
from
JSU-419-ROS_site_fix
base: dev-env
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BCMOHAM-26040: Adding new HA ID login option into backend and frontend code
* Cleaned up several unnecessary scripts that were added during the introduction of the TypeScript compile step. * Update the CronJob YAML files to match the current OpenShift configuration
… for BCeID users. (#1114) It causes a display issue on the Employer welcome page for BCeID users (first name and last name not displayed). We now display the BCeID username instead.
Updated ha id option + Fix for First name and Last name variables are not sent from Keycloak anymore for BCeID users
…low and add steps to appry cronjob changes (#1116)
No code change (Test openshift workflow: add comment to trigger cronjob deployment)
…mation Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-c74456f1-c0e9-4400-bb7b-221d0a16a618
…rkflow Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-c74456f1-c0e9-4400-bb7b-221d0a16a618
Update deployment documentation on README
Update deployment documentation on README
* Update deployment documentation to reflect infrastructure change automation * Complete production deployment documentation based on promote-prod workflow * Upgrade root package.json dependencies to latest compatible versions * MAJOR UPGRADE: Node.js engines, Express 5.x, React 19.x * COMPATIBILITY FIX: Downgrade React Router to v5.3.4 * Downgrade React from v19 to v18 for Material-UI v4 * Replace body-parser with express.json() for Express v5 upgrade * Nodejs upgrade from v20 to v24 * Fix root npm dependencies and npm-run-all script syntax * Update docker versions on Docker files and fix the statusFilters * Global and Frontend modules upgrades * Update nodejs version on format check workflow * Fix errors and warnings scanned by Format check workflow, and update eslint to v9 on server code * adding regex to support dev and test domains * updating new cert in documents and pipelines --------- Co-authored-by: Dinh Nguyen Pham <nguyenphamswork@gmail.com> Co-authored-by: Dinh Nguyen Pham <63203684+npham49@users.noreply.github.com>
Removing freshworks.club references in front-end code and replacing with new prefixes.
Updating string replacement for double quotes
Updating nonce to be inserted by webpack
Fix Pagination issues on tables and adding Docs for DEV TEST Certs
* client js upgrade and fix * fix on JSU-224 * fix JSU-225 * remove debug comments
* backend library upgrades and mongodb version update * add scripts for mongo db upgrade * remove MongoDB migration scripts (not needed as production uses Helm-managed MongoDB 4.4.6) * rollback mongo.yml
* fix the email validation on participant info edit pop-up * update email validation check
… column (#1139) * fix: resolve 'a few seconds ago' display for participant Last Updated column * update comment
Fixing seeding script
* JSU-422 remove 'Add Non-Portal Hire' button for MOH Admin accounts * JSU-416 Correct the Health Authority dropdown option for employers under the 'My Sites' tab
|
npham49
approved these changes
Oct 9, 2025
Contributor
npham49
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Contributor
|
@chloe-yuu would we need to update user guides and any documentations for this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


OLD WORKFLOW
Hiring Site Employers:
❌ CANNOT see participants doing ROS at other sites
❌ CANNOT manage participants who moved to different ROS sites
ROS Site Managers:
❌ CANNOT see participants doing ROS at their site (if hired elsewhere)
❌ CANNOT manage or archive ROS participants at their site
❌ DO NOT receive ROS completion notifications
❌ CANNOT perform any actions on ROS participants
MOH/HA Users:
NEW WORKFLOW (the Changes)
Hiring Site Employers:
Current ROS Site Managers:
MOH/HA Users:
Before: Only hiring site managers could manage ROS participants
After: Both hiring site managers AND current ROS site managers can manage ROS participants