Skip to content

this should break the build #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bc3tech wants to merge 2 commits into
base: main
Choose a base branch
from
Open

this should break the build #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57cefad
this should break the build
bc3tech Nov 5, 2025
3e0d021
dotnet test too smart
bc3tech Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/pr-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,8 @@ jobs:
with:
dotnet-version: "8.x"

- name: Build & Run UTs
run: dotnet test src/Yaap.sln -c ${{ matrix.configuration }}
- name: Build
run: dotnet build src/Yaap.sln -c ${{ matrix.configuration }}

- name: Run UTs
run: dotnet test src/Yaap.sln -c ${{ matrix.configuration }} --no-build
2 changes: 1 addition & 1 deletion src/SemanticKernel/Server/YaapServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
protected override Task<THelloResponse> HandleHelloCustomAsync(YaapClientDetail clientDetail, CancellationToken cancellationToken)
{
_log.AddingExpertNameToSemanticKernelPlugins(clientDetail.Name);
_log.ClientDetail(clientDetail);
_log.ClientDetail(clientDetail)

Check failure on line 36 in src/SemanticKernel/Server/YaapServer.cs

View workflow job for this annotation

GitHub Actions / pr-check (Debug) 

; expected

Check failure on line 36 in src/SemanticKernel/Server/YaapServer.cs

View workflow job for this annotation

GitHub Actions / pr-check (Debug) 

; expected

Check failure on line 36 in src/SemanticKernel/Server/YaapServer.cs

View workflow job for this annotation

GitHub Actions / pr-check (Release) 

; expected

Check failure on line 36 in src/SemanticKernel/Server/YaapServer.cs

View workflow job for this annotation

GitHub Actions / pr-check (Release) 

; expected

kernel.ImportPluginFromFunctions(clientDetail.Name, [kernel.CreateFunctionFromMethod(
async (string prompt) => await CallExpertAsync(clientDetail, prompt, cancellationToken),
Expand Down
Loading