Fix unused qualifications in runfiles

[palfrey]

Fixes #3493

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[palfrey]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Fixed

[UebelAndre]

Thanks! Just one question.

[palfrey]

Thanks! Just one question.

What's the question?

[UebelAndre]

What's the question?

Haha super strange, I don't know how I failed to post it. Added it now!

[UebelAndre]

What is this flag? I'm not familiar with -D flags for rustc and would love to know if there's more that can be added.

[dzbarsky]

it's a lint flag, D == Deny

[dzbarsky]

I think we could also #deny(all) in the code, at least for this runfiles lib that will be imported by user code

[palfrey]

https://rust-unofficial.github.io/patterns/anti_patterns/deny-warnings.html notes the sorts of issues there. I've redone things with #![deny] though

[illicitonion]

I'm not sure we want to sign up to maintain arbitrary style choices for people who depend on rules_rust... How does this code end up triggering these problems for you? As far as I'm aware, both Bazel and Cargo apply different lint expectations to your own code vs your dependencies...

[dzbarsky]

I'm not sure we want to sign up to maintain arbitrary style choices for people who depend on rules_rust... How does this code end up triggering these problems for you? As far as I'm aware, both Bazel and Cargo apply different lint expectations to your own code vs your dependencies...

rules_rust emits --cap-lints=allow for all crate_universe deps (third-party) but the runfiles lib is not one of those. From bazel's POV it's a "first-party" target even though it comes from an external repo. And this repo never sets the flag on the rust_library, so tweaking that would be another way to fix this.

Whichever way we move forward with, I would have hoped that a PR doing a bit of warning cleanup/hygiene would not become so contentious.