Fix regression regarding installing repos with custom tag #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…banCompass/hnvm@v0.15.10` with no custom folder name would result in an error
joseph-galindo
approved these changes
Nov 7, 2025
Comment on lines
+64
to
+66
| if [ "$custom_folder" = "false" ]; then | ||
| folder="$package" | ||
| fi |
There was a problem hiding this comment.
Ah okay I had it backwards, so the regression was related to adding support for the new custom folder arg. Which explains why I couldn't see it on really old basher releases (they didn't have the custom folder arg yet).
Thanks for looking into this, this lgtm.
|
|
||
| if [[ "$package" = */*@* ]]; then | ||
| IFS=@ read -r package ref <<< "$package" | ||
| if [ "$custom_folder" = "false" ]; then |
There was a problem hiding this comment.
L38 nit
"argunment" -> "argument"
Not really related to this PR, I noticed it and wanted to at least write it down
joseph-galindo
approved these changes
Nov 7, 2025
|
|
||
| assert_line "basher-_clone false github.com username/package v1.2.3" | ||
| assert_line "basher-_deps username/package" | ||
| assert_line "basher-_link-bins username/package" |
juanibiapina
approved these changes
Nov 18, 2025
Member
|
Thanks for the contributions and review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #130, running something like
basher install UrbanCompass/hnvm@v0.15.10would result in an error like
find: /Users/joseph.galindo/.basher/cellar/packages/UrbanCompass/hnvm@v0.15.10: No such file or directoryThis regression was introduced in e4fea83. (By me 😅). The version is stripped from the package name but not from the folder name. Thus there is a mismatch and the linking fails.
I've also enhanced one of the test cases to catch this in future