refactor: split storage engine into focused submodules #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
🟡 Heimdall Review Status
|
Split src/storage/engine.rs (3,817 lines) into 8 smaller, focused modules: - mod.rs (142 lines): Core StorageEngine struct and public API - error.rs (43 lines): Error enum and From implementations - read.rs (192 lines): get_account, get_storage, get_value_from_page - write.rs (282 lines): set_values, set_values_in_page, set_values_in_cloned_page - handlers.rs (709 lines): Trie modification handlers (branch/leaf operations) - page_ops.rs (281 lines): allocate, orphan, clone, split pages - helpers.rs (161 lines): Utility functions (prefix matching, subtrie ops) - tests.rs (2,286 lines): Extracted test module
Split src/node.rs (1,230 lines) into 5 smaller, focused modules: - mod.rs (348 lines): Node struct, NodeKind enum, TrieValue, core methods - encoding.rs (247 lines): Value trait impl for page storage serialization - rlp.rs (157 lines): Encodable trait impl for state root computation - arbitrary.rs (59 lines): Proptest strategies for fuzzing - tests.rs (488 lines): Extracted test module All non-test modules are now under 350 lines with clear responsibilities: - encoding.rs: Binary serialization for slotted page format - rlp.rs: RLP encoding for Merkle Patricia Trie computation
BrianBland
force-pushed
the
split-large-files
branch
from
63f5fc0 to
31583e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split src/storage/engine.rs (3,817 lines) into 8 smaller, focused modules: