-
Notifications
You must be signed in to change notification settings - Fork 10
feat: add three button navbar #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c5d530e to
b0d61f9
Compare
3fd42a3 to
2ac8eab
Compare
b7c5c01 to
a99dcf7
Compare
lib/src/adaptive/widgets/layers/gesture_indicator_system_nav_bar_layer.dart
Outdated
Show resolved
Hide resolved
|
Score pana : 160/160 |
|
@alexisdelage if you add the tree buttons. You should add the all the options available on pixel 9: |
@T-moz Do you have an example of what 2-buttons look like? I never saw this option before. Also not sure if it is useful, since the main goal here is to anticipate bigger bottom safe-area (I doubt 2-button navigation bar would be bigger in height than 3-button) |
07b678f to
d513d9c
Compare
…ster because it is extensions on WidgetTester
BREAKING: WindowConfigData.homeIndicator renamed to systemNavBar
All goldens are updated because of the inner padding in TextField that has been updated
607a7f3 to
d70a3c8
Compare
d70a3c8 to
7013a90
Compare

Description
Add a feature to test with a 3-button system navigation bar.
Re-use the Pixel5 config, but with the optional parameter for displaying the 3-button navbar instead of the default gestures-navigation.
Why
Being able to test an app with a large bottom safe-area, especially given the fact that
Scaffolddoes not always add the bottom safe area on our screens.