Changes made to my repo by sdpenguin #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The data argument is passed to determine the save or stored location of MNIST npy.
The user will now be prompted to train if testing is run in the absence of a h5 store.
Restructured the parameters and configuration. * Config is now supplied via an indepenent object * Moved functions to utilities + Neatened and added descriptions * Clarified folder paths * General tidy up * Added auxiliary cmd line arguments to help with new Config structure
* Fix equation parsing error by not using str on an Equations object * Refactor to provide a streamlined API for the NeuronGroup and Synapse classes * Put Parameters as class variables rather than defined in code where possible
These are not global parameters and as such should not be included in the config object.
(Simulation Now Working) The custom_namespace argument parsing has been fixed.
It was only one line.
* Neatened simulation by moving lots of configuration to the config object instead. * Removed the redundant record_arguments function, and instead set the run parameters for metadata using config.__dict__
Moved configuration parameters from the simulation function to the Config object.
Some variable names were undefined.
This method abstracts the connection forming process and neatens the get_initial_weights function.
* Redundant parameters have been removed * Defaults have been set in the Config object and no longer rely on conditional logic as heavily
Replace : with _ to make folder names better for Windows.
Changes made to my repo by sdpenguin
Owner
Author
|
Tried Sensible next steps are probably the following:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local repo continuation of #1.