-
Notifications
You must be signed in to change notification settings - Fork 25
show more context when deserialization errors occur #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
show more context when deserialization errors occur #78
Conversation
|
Another idea could be to just use |
yeah, that's a good idea too, and it's less noise in the API. happy to rewrite the PR that way |
That'd be my preference but not sure what others think :) |
|
done, lmk what you think |
d155346 to
fbf5e34
Compare
|
rebased on master and resolved conflicts |
|
CI failure looks unrelated: 0s |
this helps to debug when the API breaks, and helped me figure out what was wrong when Monad was added
9e8e665 to
57af0ed
Compare
this adds a new pattern for handling errors when json bodies don't match the rust schema, so that the errors include more detail of what didn't deserialize. this helped me figure out what was wrong when the get_assets endpoint failed when monad was added