Skip to content

Conversation

@himani2411
Copy link
Contributor

@himani2411 himani2411 commented Dec 30, 2025

Description of changes

Tests

  • PASSED
test-suites:
  basic:
    test_essential_features.py::test_essential_features:
      dimensions:
        - regions: [{{ US_EAST_1_INSTANCE_TYPE_0_xlarge_CAPACITY_RESERVATION_8_INSTANCES_2_HOURS_NOPG_OS_X86_1 }}]
          instances: [{{ US_EAST_1_INSTANCE_TYPE_0 }}.xlarge]
          oss: [{{ DCV_OS_X86_1 }}]
          schedulers: ["slurm"]
  health_checks:
    test_gpu_health_checks.py::test_cluster_with_gpu_health_checks:
      dimensions:
        - regions: [{{ US_WEST_2_GPU_INSTANCE_TYPE_0_CAPACITY_RESERVATION_3_INSTANCES_2_HOURS_NOPG_OS_X86_5 }}]
          instances: [{{ US_WEST_2_GPU_INSTANCE_TYPE_0 }}]
          oss: [{{ OS_X86_5 }}]
          schedulers: ["slurm"]

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@himani2411 himani2411 requested review from a team as code owners December 30, 2025 17:59
@himani2411 himani2411 added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Dec 30, 2025
@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.18%. Comparing base (820e0d9) to head (2e79439).
⚠️ Report is 35 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7181   +/-   ##
========================================
  Coverage    90.18%   90.18%           
========================================
  Files          183      183           
  Lines        16565    16565           
========================================
  Hits         14939    14939           
  Misses        1626     1626           
Flag Coverage Δ
unittests 90.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hehe7318
hehe7318 previously approved these changes Dec 30, 2025
xlarge_instances.add(instance_type_name)
# Get a list of only GPU instances of any size available in the region
if (
instance_type_name.startswith("p") or instance_type_name.startswith("g")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure only p/g types are GPU instance? What about trn instances?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trn has NeuronInfo instead of GPuInfo, which describe's the in-house inference chip we create.

for GPU so far I have found only these p and g family

…ltering

* Use data structures which will handle duplicates automatically
* Remove redundant calls to  DescribeInstanceType
@himani2411 himani2411 merged commit cab50e5 into aws:develop Dec 31, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x skip-changelog-update Disables the check that enforces changelog updates in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants