Fixed fleaky test (#82)

liwenwu-amazon · web-flow · commit 5ed899d3e04e · 2023-02-02T10:17:36.000-08:00
* Fixed fleaky test

* remove debugging msg in unit test
diff --git a/pkg/gateway/model_build_rule_test.go b/pkg/gateway/model_build_rule_test.go
@@ -270,8 +270,8 @@ func Test_RuleModelBuild(t *testing.T) {
 		var i = 1
 		for _, resRule := range resRules {
 
-			ruleID := fmt.Sprintf("rule-%d", i)
-			assert.Equal(t, resRule.Spec.RuleID, ruleID)
+			fmt.Sscanf(resRule.Spec.RuleID, "rule-%d", &i)
+
 			assert.Equal(t, resRule.Spec.ListenerPort, int64(tt.gwListenerPort))
 			assert.Equal(t, resRule.Spec.RuleType, "HTTPRouteMatch")
 			assert.Equal(t, resRule.Spec.ServiceName, tt.httpRoute.Name)
@@ -292,7 +292,6 @@ func Test_RuleModelBuild(t *testing.T) {
 				}
 				j++
 			}
-			i++
 
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -270,8 +270,8 @@ func Test_RuleModelBuild(t *testing.T) {`
`270`	`270`	`var i = 1`
`271`	`271`	`for _, resRule := range resRules {`
`272`	`272`
`273`		`- ruleID := fmt.Sprintf("rule-%d", i)`
`274`		`- assert.Equal(t, resRule.Spec.RuleID, ruleID)`
	`273`	`+ fmt.Sscanf(resRule.Spec.RuleID, "rule-%d", &i)`
	`274`	`+`
`275`	`275`	`assert.Equal(t, resRule.Spec.ListenerPort, int64(tt.gwListenerPort))`
`276`	`276`	`assert.Equal(t, resRule.Spec.RuleType, "HTTPRouteMatch")`
`277`	`277`	`assert.Equal(t, resRule.Spec.ServiceName, tt.httpRoute.Name)`
`@@ -292,7 +292,6 @@ func Test_RuleModelBuild(t *testing.T) {`
`292`	`292`	`}`
`293`	`293`	`j++`
`294`	`294`	`}`
`295`		`- i++`
`296`	`295`
`297`	`296`	`}`
`298`	`297`