Skip to content

Commit 96b3127

Browse files
Non default ns (#81)
* Update readme on how to run in debug mode * Set serviceimport namespace instead of hard code to default
1 parent 02172fa commit 96b3127

File tree

3 files changed

+9
-0
lines changed

3 files changed

+9
-0
lines changed

README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ kubectl apply -f config/crds/bases/multicluster.x-k8s.io_serviceimports.yaml
2121

2222
# Run the controller against the Kubernetes cluster pointed to by `kubectl config current-context`
2323
make run
24+
25+
# or run it in debug mode
26+
GATEWAY_API_CONTROLLER_LOGLEVEL=debug make run
2427
```
2528

2629
## End-to-End Testing

pkg/gateway/model_build_listener.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,9 @@ func (t *latticeServiceModelBuildTask) buildListener(ctx context.Context) error
111111
if string(*httpBackendRef.Kind) == "ServiceImport" {
112112
is_import = true
113113
targetgroupNamespace = "default"
114+
if httpBackendRef.BackendObjectReference.Namespace != nil {
115+
targetgroupNamespace = string(*httpBackendRef.BackendObjectReference.Namespace)
116+
}
114117
targetgroupName = string(httpBackendRef.BackendObjectReference.Name)
115118

116119
}

pkg/gateway/model_build_rule.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,9 @@ func (t *latticeServiceModelBuildTask) buildRules(ctx context.Context) error {
7070
*/
7171
ruleTG.Name = string(httpBackendRef.BackendObjectReference.Name)
7272
ruleTG.Namespace = "default"
73+
if httpBackendRef.BackendObjectReference.Namespace != nil {
74+
ruleTG.Namespace = string(*httpBackendRef.BackendObjectReference.Namespace)
75+
}
7376
ruleTG.IsServiceImport = true
7477

7578
if httpBackendRef.Weight != nil {

0 commit comments

Comments
 (0)