Add Atom.t() to Elixir type specs so either String.t() or Atom.t() is accepted #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onno-vos-dev
force-pushed
the
add-atom-to-elixir-type-specs
branch
from
1cedcd1 to
7a46377
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the AWS Elixir code generator to accept both String.t() and Atom.t() types in generated type specifications, addressing issue #198. The change makes the generated types more flexible by allowing either strings or atoms as map keys and string parameters.
- Updates all string type specifications to union types that accept both String.t() and Atom.t()
- Modifies code generation templates to output the new union types
- Updates test expectations to reflect the new type specifications
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/aws_codegen/types.ex | Core type generation logic updated to emit String.t() | Atom.t() union types |
| priv/rest.ex.eex | REST API template updated to generate union types for map keys |
| priv/post.ex.eex | POST API template updated to generate union types for map keys |
| test/aws_codegen_test.exs | Test expectations updated to match new union type specifications |
onno-vos-dev
force-pushed
the
add-atom-to-elixir-type-specs
branch
from
591d76e to
1c41051
Compare
onno-vos-dev
force-pushed
the
add-atom-to-elixir-type-specs
branch
from
1c41051 to
f617eb0
Compare
grant-zukowski-xumo
approved these changes
Aug 5, 2025
grant-zukowski-xumo
left a comment
grant-zukowski-xumo
left a comment
There was a problem hiding this comment.
I checked this with our local tool and all the calls work fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes aws-beam/aws-elixir#198
Await for verification from reporter before merging