Request Empty Rounds From Block Proposer #309
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
reviewed
Dec 9, 2025
epoch.go
Outdated
| } | ||
|
|
||
| func (e *Epoch) sendMissingRoundsRequest(to NodeID, missingRounds []uint64) { | ||
| e.Logger.Info("Requesting missing empty notarizations for rounds", |
Collaborator
There was a problem hiding this comment.
why is Info? can't it be debug?
yacovm
approved these changes
Dec 24, 2025
Collaborator
yacovm
left a comment
yacovm
left a comment
There was a problem hiding this comment.
It's kind of annoying that is sends redundant requests after receiving the empty notarization:
[12-24|22:30:25.621] DEBUG Simplex/requestor.go:159 Node is behind, attempting to request missing values {"test": "TestEpochRequestsEmptyRoundDependency", "myNodeID": 4, "value": 1, "start": 2, "end": 1, "seq requestor": false}
But given that verification of blocks happens asynchronously, I don't see an easy way of fixing this. I guess we'll have to live with it 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requests any empty notarization dependencies by sending a replication request to the block proposer.