Add issuer/signature sequence test #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SAML 2.0 protocol defines a sequence for Signature and Issuer. This test verifies that it is in the proper order, identical to the Signature/Issuer order verified on the response assertion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assertion signature/issuer sequence was being tested, but the response signature/issuer sequence wasn't. This PR adds a test that is failing because it is being added at the bottom of the SAMLResponse.
I looked into fixing and it seems a little difficult to do because the issuer tag is added here in node-samlp, but the assertion is generate in node-saml.
Any thoughts on this issue? Thanks!