feat: add more CI

[AndrewHanasiro]

Summary by CodeRabbit

• Documentation

  • Updated project title/description, added coverage badge, and added test & lint run instructions.

• Chores

  • CI updated to run a build verification step and added a linting job.
  • Coverage reporting integrated into quality tooling and configured output directory.

• Tests

  • Added a component unit test validating navigation items and the logout UI.

• Style/Types

  • Added ambient type declarations and a new dev dependency for QR code types.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Warning

Rate limit exceeded

@AndrewHanasiro has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 5 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between a8e8899 and 0afa042.

📒 Files selected for processing (3)

• README.md (2 hunks)
• test/Menu.svelte.test.ts (1 hunks)
• vite.config.ts (1 hunks)

Walkthrough

This PR updates CI to run a separate lint job and uses npm run build:check; adds TypeScript ambient declarations for Svelte, coverage reporting, a new component test and test id, package script/devDependency changes, README edits, and test coverage configuration.

Changes

Cohort / File(s)	Summary
CI Workflow \.github/workflows/continuous_integration.yml	Build job now runs npm run build:check (replacing npm run build); new Lint job added that checks out the repo, sets Node.js, installs deps, and runs npm run lint:check.
Package scripts & deps package.json	Added build:check script (runs svelte-kit sync + svelte-check with TS config); removed existing check script; added devDependency @types/qrcode.
Testing & coverage config sonar-project.properties, vite.config.ts	sonar-project.properties now sets sonar.javascript.lcov.reportPaths=./coverage/lcov.info; vite.config.ts adds test.coverage reporters ['html','lcov'] and reportsDirectory: './coverage'.
TypeScript declarations src/ambient.d.ts	Added ambient module declaration for \*.svelte files exporting a default component typed as typeof SvelteComponent.
Component testability src/routes/Menu.svelte	Added data-testid="logout-button" attribute to the logout button.
Tests test/Menu.svelte.test.ts	New test file rendering Menu.svelte, asserting navigation items (HOME, INVOICES, MFA, USERS) and hrefs, and asserting logout button presence and isDisabled class.
Project docs README.md	Title changed to "Auth+ Client", description updated, coverage badge added, Run section expanded with npm test and npm run lint, and minor formatting adjustments.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–30 minutes

• Verify CI workflow maps to available scripts (build:check, lint:check) and Node version matrix.
• Confirm build:check svelte-check args and TypeScript config compatibility.
• Ensure Vite coverage config produces ./coverage/lcov.info consumed by Sonar setting.
• Check src/ambient.d.ts syntax for Svelte component typing.
• Review the new test for flakiness and that data-testid matches the component.

Possibly related PRs

• Feature/update readme gh actions #17 — Similar CI and package script changes; overlaps workflow script updates.
• fix: sonar config #15 — Related adjustments to CI and Sonar/reporting configuration.
• feat: update #14 — Overlaps modifications to package scripts and CI build/check commands.

Poem

🐰 A hop, a lint, a build that checks,
Types snug in Svelte's tiny specs.
Tests that peek where buttons hide,
Coverage maps spread far and wide—
I nibble bugs and bound with pride. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided, leaving context about the changes, rationale, and scope completely undocumented.	Add a detailed description following the template with proposals, links, and context about why the CI changes were needed and what they accomplish.
Title check	❓ Inconclusive	The title 'feat: add more CI' is vague and generic, failing to clearly describe the specific changes made to the CI pipeline.	Use a more specific title that describes the actual changes, such as 'feat: add lint check to CI and update build script' to clarify what CI improvements were added.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6b2b40a and 689777e.

⛔ Files ignored due to path filters (1)

• package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (5)

• .github/workflows/continuous_integration.yml (1 hunks)
• README.md (2 hunks)
• package.json (2 hunks)
• sonar-project.properties (1 hunks)
• src/ambient.d.ts (1 hunks)

🔇 Additional comments (6)

package.json (2)

9-9: Verify that type-checking alone is sufficient for the Build job.

The build:check script validates TypeScript and Svelte code without producing build artifacts. While this is valuable for CI, the Build job in the workflow (line 69 of continuous_integration.yml) now only type-checks rather than actually building the application.

Consider whether the Build job should run npm run build (which produces artifacts) in addition to or instead of build:check, or rename the CI job to "Type Check" for clarity.

---

32-32: Good addition for TypeScript support.

Adding @types/qrcode provides type definitions for the qrcode library already in dependencies. The versions are compatible: qrcode latest version is 1.5.4, and @types/qrcode latest version is 1.5.6, with both falling within the same minor version range (1.5.x).

Note: TypeScript users using @types/qrcode will need to add a // @ts-ignore above the data segment because it expects data: string. Be aware of this requirement when using the qrcode library with TypeScript.

.github/workflows/continuous_integration.yml (1)

71-88: LGTM! Good separation of concerns.

The new Lint job follows the established pattern and properly separates linting from testing and building. The job structure is consistent with the other jobs in the workflow.

src/ambient.d.ts (1)

1-5: LGTM! Standard ambient declaration for Svelte components.

This ambient module declaration correctly enables TypeScript to recognize .svelte file imports. The syntax follows the standard pattern for TypeScript + Svelte projects and supports the build:check script added to the CI workflow.

README.md (2)

1-3: LGTM! Clear project identification.

The title and description updates appropriately reflect the Auth+ Client project identity.

---

7-7: LGTM! Good addition for coverage visibility.

The SonarCloud coverage badge provides quick visibility into test coverage metrics.

[coderabbitai]

Actionable comments posted: 4

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 689777e and f51b360.

📒 Files selected for processing (4)

• sonar-project.properties (1 hunks)
• src/routes/Menu.svelte (1 hunks)
• test/Menu.svelte.test.ts (1 hunks)
• vite.config.ts (1 hunks)

🧰 Additional context used

🪛 GitHub Actions: Continuous Integration on Pull Request

src/routes/Menu.svelte

[warning] 1-1: Code style issues found by Prettier. Run 'prettier --write' to fix.

test/Menu.svelte.test.ts

[warning] 1-1: Code style issues found by Prettier. Run 'prettier --write' to fix.

🔇 Additional comments (3)

src/routes/Menu.svelte (1)

26-26: Good addition of test identifier.

Adding the data-testid attribute is a best practice for component testing and properly supports the test assertions in test/Menu.svelte.test.ts.

Note: Please address the Prettier formatting warning flagged by the pipeline.

sonar-project.properties (1)

12-12: LCOV coverage path correctly aligned with Vitest configuration.

The LCOV coverage path ./coverage/lcov.info correctly matches the Vitest configuration in vite.config.ts, which specifies reporter: ['html', 'lcov'] and reportsDirectory: './coverage'. The previous concern about Clover format has been resolved by using LCOV throughout.

test/Menu.svelte.test.ts (1)

9-22: Test assertions are well-structured.

The test properly verifies navigation links, their href attributes, and the logout button's presence and initial disabled state.

Note: Please address the Prettier formatting warning flagged by the pipeline.