Skip to content

Problem operators use specific solvers #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
EdwardPalmer99 wants to merge 30 commits into
base: EdwardPalmer99/mesh-update-feature/move-solvers-to-problem-operator
Choose a base branch
from
Open

Problem operators use specific solvers #111

EdwardPalmer99 wants to merge 30 commits into from

Conversation

@EdwardPalmer99
Copy link
Contributor

@EdwardPalmer99 EdwardPalmer99 commented May 23, 2024 •
edited
Loading

Brief

  • Problem operators have specific solvers associated with them.
  • Easy to subclass existing problem operators and use custom solvers.
  • Enables Update methods to be easily implemented for custom solvers.

Potential Pitfalls
The main pitfalls (i.e. forgetting to apply solver options, etc.) have been addressed however there remain a couple of failure points. The main issue is:

  • Failing to override ApplySolverOptions. If the parent class uses a different solver then this could result in a std::bad_cast.

Added a ConstructJacobianSolver method to the ProblemOperator classes…
b40e516 
…. Problem operators now have their own specific preconditioners and solvers.
@EdwardPalmer99 EdwardPalmer99 self-assigned this May 23, 2024
@EdwardPalmer99 EdwardPalmer99 force-pushed the EdwardPalmer99/mesh-update-feature/problem-operators-for-specific-solvers branch from 376f339 to 139973a Compare May 23, 2024 13:17
Edward Palmer added 7 commits May 23, 2024 13:20
Removed ConstructJacobianSolver method from problem operator classes;…
2d7c18a 
… ConstructJacobianSolver method in problem operator classes is now called in the constructor of the base class.
Removes SetJacobianPreconditioner and SetJacobianSolver methods from …
670fd60 
…problem builder classes.
Removes ConstructTimestepper method from problem builder classes. Add…
a17308e 
…s ConstructTimestepper to TimeDomainProblemOperator class; called in constructor.
Removes ConstructNonlinearSolver from problem builder classes; adds C…
18a158d 
…onstructNonlinearSolver to problem operator classes; called in constructor.
Removed SetNonlinearSolver setter.
b388476
Moves ConstructTimestepper into TimeDomainProblemOperator::Init
9c8a27a 
This will allow the virtual method to be overriden in derived classes properly. Virtual methods will not work properly in constructors since derived classes will not yet exist.
Adds SolverOptions structure and SetSolverOptions method.
9ce6f23
@EdwardPalmer99 EdwardPalmer99 force-pushed the EdwardPalmer99/mesh-update-feature/problem-operators-for-specific-solvers branch from 139973a to 9ce6f23 Compare May 23, 2024 13:25
Edward Palmer added 19 commits May 23, 2024 13:27
Makes ConstructJacobianSolver protected in derived classes.
6d30e48
Implements SetSolverOptions for HCurlProblemOperator.
84df05c
Implements SetSolverOptions for DualOperator.
798739e
Implements SetSolverOptions for ComplexMaxwellOperator.
2383fa3
Implements SetSolverOptions for StaticsOperator.
14eb5d7
SetSolverOptions argument now passed by value.
29d3137
Updates examples to use new SetSolverOptions.
cc09a40 
Replaces clunky InputParameters setup.
Updates integration tests to use SetSolverOptions.
7482759
Removes solver input parameters from Problem and SetSolverOptions fro…
b9f3ae1 
…m ProblemBuilder.
Adds custom Update implementation for HCurlProblemOperator
fe35b42
Adds DualOperator update implementation.
1b58254
Corrected comments in ProblemOperatorBase.
c801b56
Switched order in ComplexMaxwellOperator::Update to be consistent
73f9c96
Switches order in TimeDomainEquationSystemProblemOperator::Update to …
f574312 
…be consistent.
Adds solver options member variable to store parameters; now call Con…
673d1eb 
…structJacobianSolver in base class for updates.

This is faster and much simpler than having to provide a custom update for each solver.
Removes jacobian preconditioner template accessor from ProblemOperato…
3d9071c 
…rBase.
Removes Jacobian operator handle from EquationSystem.
5046623
Removes ConstructOperator from problem classes. Implemented directly …
f57eb82 
…in problem builders.
Removed TODO comment from EquationSystemProblemOperator.
e4c038e
Edward Palmer added 3 commits May 24, 2024 10:59
Adds DefaultSolverOptions virtual method
2f97298 
Allows ProblemOperatorBase derived classes to set custom default options.
Adds ApplySolverOptions; SetSolverOptions no longer virtual and wraps…
01a2ceb 
… around ApplySolverOptions; adds ConstructJacobianSolverAndApplyOptions with wraps around ConstructJacobianSolver and ensures that solver options are applied.
SolverOptions are now private; adds GetSolverOptions accessor.
636cdfd
@EdwardPalmer99 EdwardPalmer99 marked this pull request as ready for review May 24, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexanderianblair alexanderianblair Awaiting requested review from alexanderianblair

Assignees

@EdwardPalmer99 EdwardPalmer99

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EdwardPalmer99