improvement #1
Open
improvement #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A248
reviewed
Mar 21, 2021
tick-api/src/main/java/me/aurium/tick/container/ContainerManagerImpl.java
Outdated
Show resolved
Hide resolved
tick-api/src/main/java/me/aurium/tick/container/terms/JDBCTerms.java
Outdated
Show resolved
Hide resolved
tick-api/src/main/java/me/aurium/tick/docker/machine/MachineSourceProvider.java
Outdated
Show resolved
Hide resolved
tick-api/src/main/java/me/aurium/tick/docker/machine/MachineSourceProvider.java
Outdated
Show resolved
Hide resolved
tick-api/src/main/java/me/aurium/tick/docker/machine/MachineSourceProvider.java
Outdated
Show resolved
Hide resolved
tick-api/src/main/java/me/aurium/tick/docker/machine/ShellExecutionException.java
Outdated
Show resolved
Hide resolved
A248
reviewed
Mar 23, 2021
tick-api/src/main/java/me/aurium/tick/container/container/MariaDBContainer.java
Outdated
Show resolved
Hide resolved
Owner
Author
|
Build is gonna keep failing until we merge because of java versions |
A248
reviewed
Jul 14, 2021
A248
reviewed
Jul 14, 2021
tickbox-api/src/main/java/xyz/auriium/tick/docker/source/impl/WindowsSourceProvider.java
Outdated
Show resolved
Hide resolved
Owner
Author
|
Ignore infinite build failures that's because github actions's tests are all ran in windows-container mode and not linux-container mode (which is yet another problem i have to sort out) but i can probably resolve it by replacing the alpine tinyimage in testing with docker's surprise image |
Owner
Author
|
linux tests are passing. I'd like to implement more linux tests but they will be reserved for another pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@A248 review please :)