-
Notifications
You must be signed in to change notification settings - Fork 12
Chore: building application-sdk's base image #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📜 Docstring Coverage ReportRESULT: PASSED (minimum: 30.0%, actual: 76.7%) Detailed Coverage Report |
|
🛠 Docs available at: https://k.atlan.dev/application-sdk/chainguard-image |
📦 Trivy Vulnerability Scan Results
Report Summary
Scan Result Details✅ No vulnerabilities found during the scan for |
📦 Trivy Secret Scan Results
Report Summary
Scan Result Details✅ No secrets found during the scan for |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
|
🛠 Full Test Coverage Report: https://k.atlan.dev/coverage/application-sdk/pr/892 |
…o use that action
…ngs from Dockerfile
token does not have permissions to push to dockerhub. Getting this error message : #31 exporting to image #31 pushing layers 0.4s done #31 ERROR: failed to push registry-1.docker.io/atlanhq/application-sdk:chainguard-image-a13ffd1abcd: failed to authorize: failed to fetch oauth token: unexpected status from GET request to https://auth.docker.io/token?scope=repository%3Aatlanhq%2Fapplication-sdk%3Apull%2Cpush&service=registry.docker.io: 401 Unauthorized: access token has insufficient scopes ------ > exporting to image: ------ ERROR: failed to build: failed to solve: failed to fetch oauth token: unexpected status from GET request to https://auth.docker.io/token?scope=repository%3Aatlanhq%2Fapplication-sdk%3Apull%2Cpush&service=registry.docker.io: 401 Unauthorized: access token has insufficient scopes Reference Check build summary support Error: buildx failed with: ERROR: failed to build: failed to solve: failed to fetch oauth token: unexpected status from GET request to https://auth.docker.io/token?scope=repository%3Aatlanhq%2Fapplication-sdk%3Apull%2Cpush&service=registry.docker.io: 401 Unauthorized: access token has insufficient scopes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds Docker image building infrastructure for the application-sdk using a Chainguard-based base image, along with automated CI/CD through GitHub Actions for building and publishing images with integrated security scanning.
Key Changes:
- Added Dockerfile that builds application-sdk from source using a Chainguard Python base image with comprehensive dependency installation
- Implemented GitHub Actions workflow to automatically build and push Docker images on changes to main and chainguard-image branches
- Created reusable composite action with mandatory Snyk and Trivy security scanning before image publication
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| Dockerfile | Defines multi-stage build process for application-sdk using Chainguard base image, installing Dapr CLI and Python dependencies |
| .github/workflows/build-image.yaml | Workflow that triggers on pushes to build and publish Docker images with security scanning integration |
| .github/actions/secure-build-push-apps/action.yaml | Reusable composite action that enforces Snyk and Trivy security scanning before allowing image pushes to registries |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@firecast : responded to all the open comments + fixed PR based on the feedback. can you please have a look and approve if all looks good. |
Changelog
Additional context (e.g. screenshots, logs, links)
Checklist
Copyleft License Compliance
Note
Introduces a base Dockerfile and a GitHub Actions workflow using a composite action to build, scan (Snyk/Trivy), and push multi-arch images to GHCR.
Dockerfilefromghcr.io/atlanhq/pyatlan-chainguard-base:8.3.0-3.11installing Dapr CLI, addinguv, creatingappuser, initializing Dapr (slim), removing unused Dapr binaries, and defining common env vars and defaultCMD./.github/actions/secure-build-push-appsto build single-platform for scan, run Snyk and Trivy, decide pass/fail, then build and optionally push multi-platform images; includes Snyk registry import/monitor fallback./.github/workflows/build-image.yamlto build and push to GHCR on pushes (main/chainguard-image), tagginglatestand short-sha-based versions, using the composite action..dockerignoreto minimize build context.Written by Cursor Bugbot for commit b773c50. This will update automatically on new commits. Configure here.