Migrate Symfony Commands to NestJS #14
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d7ed55a.
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5 to 6. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v5...v6) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [peter-evans/dockerhub-description](https://github.com/peter-evans/dockerhub-description) from 4 to 5. - [Release notes](https://github.com/peter-evans/dockerhub-description/releases) - [Commits](peter-evans/dockerhub-description@v4...v5) --- updated-dependencies: - dependency-name: peter-evans/dockerhub-description dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [api-platform/core](https://github.com/api-platform/core) from 4.2.0 to 4.2.1. - [Release notes](https://github.com/api-platform/core/releases) - [Changelog](https://github.com/api-platform/core/blob/v4.2.1/CHANGELOG.md) - [Commits](api-platform/core@v4.2.0...v4.2.1) --- updated-dependencies: - dependency-name: api-platform/core dependency-version: 4.2.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [brianium/paratest](https://github.com/paratestphp/paratest) from 7.13.0 to 7.14.1. - [Release notes](https://github.com/paratestphp/paratest/releases) - [Commits](paratestphp/paratest@v7.13.0...v7.14.1) --- updated-dependencies: - dependency-name: brianium/paratest dependency-version: 7.14.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/upload-pages-artifact](https://github.com/actions/upload-pages-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-pages-artifact/releases) - [Commits](actions/upload-pages-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/upload-pages-artifact dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Setup apt/rpm repository, improved documentation and autogeneration. Fix ubuntu tests * Fix translations * Added sleep to the nsis installer to finish * Fixed links in README.md * Publish Windows installer in Chocolatey and WinGet on release * Specifiy user for fork * Improved documentation, avoid build documentation and sign installers on forks * Improved documentation, avoid build documentation and sign installers on forks * Avoid deploy pages in forks * Remove VirusTotal as choco is already uploading the installer to virustotal. Fix exelearning#340
Bumps [symfony/translation](https://github.com/symfony/translation) from 7.3.3 to 7.3.4. - [Release notes](https://github.com/symfony/translation/releases) - [Changelog](https://github.com/symfony/translation/blob/7.3/CHANGELOG.md) - [Commits](symfony/translation@v7.3.3...v7.3.4) --- updated-dependencies: - dependency-name: symfony/translation dependency-version: 7.3.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ernesto Serrano Co-authored-by: Ignacio Gros
Bumps [symfony/framework-bundle](https://github.com/symfony/framework-bundle) from 7.3.3 to 7.3.4. - [Release notes](https://github.com/symfony/framework-bundle/releases) - [Changelog](https://github.com/symfony/framework-bundle/blob/7.3/CHANGELOG.md) - [Commits](symfony/framework-bundle@v7.3.3...v7.3.4) --- updated-dependencies: - dependency-name: symfony/framework-bundle dependency-version: 7.3.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ernesto Serrano Co-authored-by: Ignacio Gros
…a loss on PUT requests (exelearning#362) * Revert "Bump symfony/serializer from 7.3.3 to 7.3.4 (exelearning#333)" This reverts commit d7ed55a. * Refactor DefaultApiController to use SerializerInterface and upgrade Symfony serializer
Bumps [symfony/twig-bundle](https://github.com/symfony/twig-bundle) from 7.3.2 to 7.3.4. - [Release notes](https://github.com/symfony/twig-bundle/releases) - [Changelog](https://github.com/symfony/twig-bundle/blob/7.3/CHANGELOG.md) - [Commits](symfony/twig-bundle@v7.3.2...v7.3.4) --- updated-dependencies: - dependency-name: symfony/twig-bundle dependency-version: 7.3.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ernesto Serrano Co-authored-by: Ignacio Gros
* Adjust variables * Added vars to sign mac installer
* Added some options to improve performance on sqlite * Fix some cascading errors
* Fix: Handle legacy provider format in extractProviderId method * Fix: Normalize provider ID by removing '_legacy' suffix in isValidProvider method * Fix: Improve error handling in platformPetitionSet method to include user-friendly error message * refactor code
…rning#373) * Fixed ?q=/workarea parameter, so now CAS works with BASE_PATH, improved documentation, add a hotfix for avoid src/var files * Fixed tests * Cherrypicked tests/Integration/Api/TreeValidationTest.php to avoid errors * Removed fix in Dockerfile because updted erseco/alpine-php-webserver image * Updated docs
* new iDevices style * base.css should only include CSS required for exported contents. * CSS structure to SCSS. --------- Co-authored-by: ignaciogros
* Update logo image source in README.md * Update README.md
* Revert "Bump symfony/serializer from 7.3.3 to 7.3.4 (exelearning#333)" * Fix prama sqlite settings for tests * Remove foreign keys PRAGMA setting for SQLite * Removed the PRAGMA foreign_keys setting to allow default behavior. There are many errors on Symfony when using them * Remove foreign keys assertion and concurrent writers test * Removed assertions for foreign keys and deleted a test for concurrent writers.
Bumps [friendsofphp/php-cs-fixer](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer) from 3.88.2 to 3.89.2. - [Release notes](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/releases) - [Changelog](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/CHANGELOG.md) - [Commits](PHP-CS-Fixer/PHP-CS-Fixer@v3.88.2...v3.89.2) --- updated-dependencies: - dependency-name: friendsofphp/php-cs-fixer dependency-version: 3.89.2 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [symfony/validator](https://github.com/symfony/validator) from 7.3.4 to 7.3.6. - [Release notes](https://github.com/symfony/validator/releases) - [Changelog](https://github.com/symfony/validator/blob/7.3/CHANGELOG.md) - [Commits](symfony/validator@v7.3.4...v7.3.6) --- updated-dependencies: - dependency-name: symfony/validator dependency-version: 7.3.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [symfony/intl](https://github.com/symfony/intl) from 7.3.4 to 7.3.5. - [Release notes](https://github.com/symfony/intl/releases) - [Changelog](https://github.com/symfony/intl/blob/7.3/CHANGELOG.md) - [Commits](symfony/intl@v7.3.4...v7.3.5) --- updated-dependencies: - dependency-name: symfony/intl dependency-version: 7.3.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [doctrine/orm](https://github.com/doctrine/orm) from 3.5.2 to 3.5.3. - [Release notes](https://github.com/doctrine/orm/releases) - [Commits](doctrine/orm@3.5.2...3.5.3) --- updated-dependencies: - dependency-name: doctrine/orm dependency-version: 3.5.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Mermaid diagrams rendering support via TinyMCE plugin, by @lrlopez. * TinyMCE Mermaid plugin and licenses revision. * Mermaid contents presentation revision.
…ng#659) * Adding default values to work as OFFLINE by default * Fix lint issues * Add volume * Set online as default
…exelearning#662) Bumps the composer group with 1 update in the / directory: [symfony/http-foundation](https://github.com/symfony/http-foundation). Updates `symfony/http-foundation` from 7.3.5 to 7.3.7 - [Release notes](https://github.com/symfony/http-foundation/releases) - [Changelog](https://github.com/symfony/http-foundation/blob/7.3/CHANGELOG.md) - [Commits](symfony/http-foundation@v7.3.5...v7.3.7) --- updated-dependencies: - dependency-name: symfony/http-foundation dependency-version: 7.3.7 dependency-type: indirect dependency-group: composer ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… exported in EPUB when searching for content
…packages exported in EPUB when searching for content" This reverts commit 19ab907.
* Preparing ChangeLog file. * Available languages in alphabetical order. * Fix TinyMCE fullscreen mode z-index problem (you can't select the last line). * Progress bar presentation revision (colors). * Package subtitle presentation. * Missing package subtitle in the single page export. * Partial styles revision. * Temporally hide "New from template...". * Renamed CSS class for highlighted links in the navigation menu. * Stronger CSS definitions for the effects. * Login page presentation revision.
- Complete analysis of current Symfony 7.3 architecture - Equivalence mapping between Symfony and NestJS components - 10-phase migration strategy (6-9 months timeline) - Detailed architecture design for NestJS backend - Risk assessment and mitigation strategies - Resource planning and cost estimation - Special focus on OdeService.php migration (123K lines) - Coexistence strategy for gradual rollout
MAJOR CHANGES: - Discovered eXeLearning is Electron app (NOT web app) - Only 1 Twig template to migrate (workarea.html.twig → workarea.njk) - Frontend is JavaScript vanilla (NO React/Vue) - NO CHANGES needed - 69 legacy API controllers to migrate (NOT /api/v2 - doesn't exist) - Recommend Nunjucks for templates (NOT TSX - incompatible) - Replace Mercure with Socket.io for WebSockets - Better Electron + Node.js integration (vs PHP embedded) KEY FINDINGS: - Architecture: Electron + Symfony (PHP) + JavaScript vanilla - Single SSR: Twig renders /workarea ONCE, then JS takes over - All operations via REST API after initial render - 123K lines OdeService.php needs split into multiple services - Timeline: 5-9 months (23-38 weeks) SIMPLIFIED MIGRATION: ✅ Fewer templates (1 vs many) ✅ Frontend unchanged (JavaScript vanilla compatible) ✅ Clear API boundaries (69 controllers) ✅ Better stack unification (JS/TS everywhere)
This prompt defines all requirements for eXeLearning 4.0 architecture: SCOPE: - Complete migration from Symfony + PHP to NestJS + Vite - Single unified interface (online/offline modes) - SQLite only (simplified from multi-DB support) - Makefile-based project management - PR preview deployments STACK: - Backend: NestJS + TypeORM + SQLite - Frontend: Vite + React/Vue (to be decided) - Desktop: Electron - CLI: Commander.js with shared core - MCP: AI resource generation server KEY REQUIREMENTS: - 20 detailed sections covering all aspects - Monorepo structure with shared code - Comprehensive testing strategy - GitHub Actions for CI/CD + PR previews - Export system for SCORM/HTML5/EPUB3 - Real-time collaboration with Socket.io - Embeddable in LMS (Moodle, WordPress) DELIVERABLES REQUESTED: 1. Complete architecture document 2. Project structure definition 3. Database schema with TypeORM 4. API specifications 5. Configuration files 6. Package.json templates 7. GitHub Actions workflows 8. Type definitions 9. Testing strategy 10. Developer guide This prompt will be used by an AI agent to generate the complete architecture blueprint for the migration project.
Migrates the following Symfony commands to NestJS using nest-commander: - app:jwt:generate - app:user:role - app:jwt:validate - app:validate-providers Includes the creation of a new `CommandsModule` and the necessary services to support the commands.
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
erseco
force-pushed
the
epic/migrate-to-nestjs
branch
from
a8fd96a to
d47e25b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change migrates four Symfony console commands to a new NestJS
CommandsModuleusing thenest-commanderlibrary. The migrated commands include tools for JWT generation and validation, user role management, and platform provider configuration validation. A new entry point (src/command.ts) has been created to handle CLI commands separately from the web application. TheProviderConfigurationServicehas been implemented to provide the logic for theapp:validate-providerscommand, addressing the feedback from the code review.Fixes #
PR created automatically by Jules for task 4459351032088406716 started by @erseco