Skip to content

fix: update Slack invite links to open external URL in new tab #4841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ika12345 wants to merge 10 commits into
base: master
Choose a base branch
from
Open

fix: update Slack invite links to open external URL in new tab #4841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9826120
fix: update Slack invite links to open external URL in new tab
ika12345 Jan 1, 2026
3ffa24d
Merge branch 'master' into fix/slack-join-button-link
ika12345 Jan 1, 2026
256db66
Fix Slack CTA external link target
ika12345 Jan 1, 2026
bc1d07e
Re-trigger CI
ika12345 Jan 1, 2026
d20e692
Fix lint issues for Slack CTA PR
ika12345 Jan 1, 2026
13ab1d0
chore: fix lint issues for Slack invite update
ika12345 Jan 1, 2026
c32f4fb
chore: clean up SlackButton imports and formatting
ika12345 Jan 1, 2026
ceb4f48
restore SlackButton JSDoc
ika12345 Jan 4, 2026
f70db87
fix: restore Slack redirect to external Slack invite
ika12345 Jan 4, 2026
ec327f3
Restore slackbutton and Slack CTA to original behavior
ika12345 Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pages/community/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ export default function CommunityIndexPage() {
actively contribute, collaborate, and mentor others on how to
build with AsyncAPI."
btnText='Join AsyncAPI slack'
link='https://asyncapi.com/slack-invite'
link='https://www.asyncapi.com/slack-invite'
Copy link
Member

@anshgoyalevil anshgoyalevil Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need to include a www cname?

className='bg-channelCover'
/>
</div>
Expand Down
2 changes: 2 additions & 0 deletions public/_redirects
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ https://www.asyncapi.io/* https://www.asyncapi.com/:splat 301!
# Slack
/slack-invite https://join.slack.com/t/asyncapi/shared_invite/zt-3m4pmrguv-SUN9Js4BkQHocIH54F59sA 302!
Copy link
Member

@anshgoyalevil anshgoyalevil Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this would result in a redirect loop. why are we removing the slack invite link here?




# Central Maven repository verification
/OSSRH-63280 https://github.com/asyncapi/java-asyncapi
# Central Gradle repository verification
Expand Down