-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: using CloudEvents with AsyncAPI #4819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: using CloudEvents with AsyncAPI #4819
Conversation
A new section "Message Formats" to describe how message formats can be used in AsyncAPI. Starting with the use case to add CloudEvents envelopes.
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThree new documentation files are added to the reference section, establishing a message formats subsection. Files include metadata configuration, an index with contribution guidelines, and CloudEvents format documentation covering Structured and Binary modes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4819 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 798 798
Branches 146 146
=========================================
Hits 798 798 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
markdown/docs/reference/message-formats/index.md (1)
17-17: Fix compound adjective hyphenation.Line 17 uses "AsyncAPI specific trait" when it should be hyphenated as "AsyncAPI-specific trait" (compound adjectives before nouns require hyphens).
🔎 Proposed fix
-If an AsyncAPI specific trait is needed, a pull request to the [Components Catalog](https://github.com/asyncapi/spec/tree/master/components) can be made to include it. +If an AsyncAPI-specific trait is needed, a pull request to the [Components Catalog](https://github.com/asyncapi/spec/tree/master/components) can be made to include it.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
markdown/docs/reference/message-formats/_section.mdmarkdown/docs/reference/message-formats/cloudevents.mdmarkdown/docs/reference/message-formats/index.md
🧰 Additional context used
🪛 LanguageTool
markdown/docs/reference/message-formats/index.md
[grammar] ~17-~17: Use a hyphen to join words.
Context: ...ference/message-formats). If an AsyncAPI specific trait is needed, a pull request...
(QB_NEW_EN_HYPHEN)
🪛 markdownlint-cli2 (0.18.1)
markdown/docs/reference/message-formats/cloudevents.md
10-10: Bare URL used
(MD034, no-bare-urls)
markdown/docs/reference/message-formats/index.md
10-10: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: cypress-run
- GitHub Check: Lighthouse CI
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Test NodeJS PR - macos-latest
🔇 Additional comments (3)
markdown/docs/reference/message-formats/_section.md (1)
1-4: LGTM!The section header is correctly configured with an appropriate weight value to position it within the documentation hierarchy.
markdown/docs/reference/message-formats/index.md (1)
6-17: Excellent introductory content and clear contribution guidance.The overview effectively explains message formats, provides practical guidance on usage in AsyncAPI documents, and includes actionable instructions for contributors. The structure and tone are well-suited for documentation.
markdown/docs/reference/message-formats/cloudevents.md (1)
6-67: Comprehensive and well-structured CloudEvents documentation.The guide effectively covers both Structured and Binary modes with clear explanations, practical examples, and helpful references. The tables provide quick reference guidance, and the YAML examples demonstrate proper usage patterns. This is excellent foundational documentation for the message formats catalog.
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4819--asyncapi-website.netlify.app/ |
Description
Related issue(s)
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.