-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(blog): prevent Next.js prefetching of static rss.xml #4811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Replaced TextLink with anchor tag for rss.xml to avoid invalid Next.js prefetch requests.
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
📝 WalkthroughWalkthroughThe PR replaces the RSS feed link rendering in the blog index page from a TextLink component to a plain HTML anchor tag. The link destination, text content, and surrounding layout remain unchanged—only the element type is modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (8)📓 Common learnings📚 Learning: 2024-10-11T11:32:30.226ZApplied to files:
📚 Learning: 2024-10-11T11:17:32.246ZApplied to files:
📚 Learning: 2024-10-11T07:27:53.362ZApplied to files:
📚 Learning: 2024-10-11T07:38:35.745ZApplied to files:
📚 Learning: 2025-12-23T06:30:43.275ZApplied to files:
📚 Learning: 2024-10-11T10:46:58.882ZApplied to files:
📚 Learning: 2025-12-29T14:21:28.216ZApplied to files:
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4811 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 798 798
Branches 146 146
=========================================
Hits 798 798 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4811--asyncapi-website.netlify.app/ |
|
duplicate of #4814. Please refrain from raising a PR before the issue is approved |
This PR replaces the usage of a Next.js link for
/rss.xmlwith a standard anchor tag.Since
rss.xmlis a static asset and not a Next.js route, usingTextLink(which internally relies on Next.js routing) caused Next.js to attempt
prefetching a non-existent
_next/dataJSON route, resulting in unnecessary404 requests.
This change aligns with Next.js best practices and removes invalid prefetching
without affecting functionality.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.