fix: update broken ambassador program link in community page #4784
Conversation
AA1-34-Ganesh
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve,
derberg,
princerajpoot20 and
sambhavgupta0705
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
📝 WalkthroughWalkthroughA single href attribute in the ambassadors page component was updated, redirecting the "Become an Ambassador now" button from a non-existent AMBASSADOR_ORGANIZATION document to the correct AMBASSADOR_PROGRAM document to resolve a 404 error. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4784 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 798 798
Branches 146 146
=========================================
Hits 798 798 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pages/community/ambassadors/index.tsx (1)
208-208: Fix correctly addresses the broken link by making both ambassador buttons consistent.The updated link now matches the header button on line 67, both pointing to the same AMBASSADOR_PROGRAM.md document. The URL is accessible and returns HTTP 200.
Consider extracting the URL to a constant to avoid duplication and improve maintainability:
const AMBASSADOR_PROGRAM_URL = 'https://github.com/asyncapi/community/blob/master/docs/020-governance-and-policies/AMBASSADOR_PROGRAM.md';Then reference this constant on both lines 67 and 208.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pages/community/ambassadors/index.tsx
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Lighthouse CI
- GitHub Check: Test NodeJS PR - windows-latest
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4784--asyncapi-website.netlify.app/ |
animeshk923
left a comment
animeshk923
left a comment
There was a problem hiding this comment.
Link opening correctly in preview deployment.
|
@animeshk923 Thanks for the help! |
|
@princerajpoot20 my pleasure! |
|
/rtm |
4 participants
Description
AMBASSADOR_ORGANIZATION.md, which resulted in a 404 error.docs/020-governance-and-policies/AMBASSADOR_PROGRAM.mdto match the working header button.Related issue(s)
Fixes #4776
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.