Skip to content

Update async directory client to match sync #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ronenh merged 2 commits into from
Nov 5, 2024
Merged

Update async directory client to match sync #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
910d768
Update async directory client to match sync
Nov 5, 2024
9aeb187
Fix async directory tests
Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/aserto/client/directory/v3/aio/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,38 +405,41 @@ async def get_relations(
@typing.overload
async def get_relation(
self,
*,
with_objects: typing.Literal[False] = False,
object_type: str = "",
object_id: str = "",
relation: str = "",
subject_type: str = "",
subject_id: str = "",
subject_relation: str = "",
with_objects: typing.Literal[False] = False,
) -> Relation:
...

@typing.overload
async def get_relation(
self,
*,
with_objects: typing.Literal[True],
object_type: str = "",
object_id: str = "",
relation: str = "",
subject_type: str = "",
subject_id: str = "",
subject_relation: str = "",
with_objects: typing.Literal[True] = True,
) -> RelationResponse:
...

async def get_relation(
self,
*,
with_objects: bool = False,
object_type: str = "",
object_id: str = "",
relation: str = "",
subject_type: str = "",
subject_id: str = "",
subject_relation: str = "",
with_objects: bool = False,
) -> typing.Union[Relation, RelationResponse]:
"""Retrieve a directory relation that matches the specified filters.
Raises a NotFoundError no matching relation is found.
Expand Down
7 changes: 6 additions & 1 deletion test/test_directory_v3_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,12 @@ async def test_delete_object(directory: Directory):

# Relations should remain intact
rel = await directory.get_relation(
"user", "morty@the-citadel.com", "manager", "user", "rick@the-citadel"
with_objects=False,
object_type="user",
object_id="morty@the-citadel.com",
relation="manager",
subject_type="user",
subject_id="rick@the-citadel.com",
)
assert rel is not None
assert rel.object_type == "user"
Expand Down
Loading