Skip to content

fix ArrayIndexOutOfBoundsException when sDots[][] index >= length #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
buffermet wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix ArrayIndexOutOfBoundsException when sDots[][] index >= length #33

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c35d51f
fix ArrayIndexOutOfBoundsException when sDots[][] index >= length
buffermet Sep 7, 2019
be234ae
Update PatternLockView.java
buffermet Sep 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions patternlockview/src/main/java/com/andrognito/patternlockview/PatternLockView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ public class PatternLockView extends View {
private float mHitFactor = 0.6f;

// Made static so that the static inner class can use it
private static Dot[][] sDots;
private static int sDotCount;

private boolean mAspectRatioEnabled;
Expand Down Expand Up @@ -578,11 +579,18 @@ public void setViewMode(@PatternViewMode int patternViewMode) {

public void setDotCount(int dotCount) {
sDotCount = dotCount;
mPatternSize = sDotCount * sDotCount;
sDots = new Dot[dotCount][dotCount];
for (int i = 0; i < dotCount; i++) {
for (int j = 0; j < dotCount; j++) {
sDots[i][j] = new Dot(i, j);
}
}

mPatternSize = dotCount * dotCount;
mPattern = new ArrayList<>(mPatternSize);
mPatternDrawLookup = new boolean[sDotCount][sDotCount];
mPatternDrawLookup = new boolean[dotCount][dotCount];

mDotStates = new DotState[sDotCount][sDotCount];
mDotStates = new DotState[dotCount][dotCount];
for (int i = 0; i < sDotCount; i++) {
for (int j = 0; j < sDotCount; j++) {
mDotStates[i][j] = new DotState();
Expand Down Expand Up @@ -1149,7 +1157,6 @@ public static class Dot implements Parcelable {

private int mRow;
private int mColumn;
private static Dot[][] sDots;

static {
sDots = new Dot[sDotCount][sDotCount];
Expand Down