Skip to content

Conversation

@ZZ-Cat
Copy link
Contributor

@ZZ-Cat ZZ-Cat commented Dec 7, 2025

This Pull Request adds the URL of my project CRSF for Arduino — A library that brings the Crossfire Protocol (better known as "CRSF") to the Arduino ecosystem.

@github-actions github-actions bot added the topic: submission Add library to the list label Dec 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

ERROR: Arduino Lint found errors with https://github.com/ZZ-Cat/CRSFforArduino:

Linting library in CRSFforArduino
WARNING: Library name CRSFforArduino contains "Arduino". This is superfluous.                                  
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP014)                                                                                          
ERROR: Missing paragraph field in library.properties                                                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP034)                                                                                          
WARNING: Missing architectures field in library.properties                                                     
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP043)                                                                                          

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

Linting sketch in CRSFforArduino/examples/flight_modes

Linter results for project: no errors or warnings

-------------------

Linting sketch in CRSFforArduino/examples/link_stats

Linter results for project: no errors or warnings

-------------------

Linting sketch in CRSFforArduino/examples/rc_channels

Linter results for project: no errors or warnings

-------------------

Linting sketch in CRSFforArduino/examples/telemetry

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 2 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

Thanks for your interest in contributing to the Arduino Library Manager index @ZZ-Cat
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@ZZ-Cat
Copy link
Contributor Author

ZZ-Cat commented Dec 7, 2025

@ArduinoBot Ding, ding! =^/.^=
I made the necessary changes. Now, let's see what happens.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

ERROR: Arduino Lint found errors with https://github.com/ZZ-Cat/CRSFforArduino:

Linting library in CRSFforArduino
WARNING: Library name CRSFforArduino contains "Arduino". This is superfluous.                                  
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP014)                                                                                          
ERROR: library.properties version value 2025.12.07 is invalid.                                               
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP020)                                                                                          
WARNING: library.properties version value 2025.12.07 is not compliant with the semver specification.
         See: https://semver.org/                                                                   
         (Rule LP021)                                                                               

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

Linting sketch in CRSFforArduino/examples/flight_modes

Linter results for project: no errors or warnings

-------------------

Linting sketch in CRSFforArduino/examples/link_stats

Linter results for project: no errors or warnings

-------------------

Linting sketch in CRSFforArduino/examples/rc_channels

Linter results for project: no errors or warnings

-------------------

Linting sketch in CRSFforArduino/examples/telemetry

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 2 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

Thanks for your interest in contributing to the Arduino Library Manager index @ZZ-Cat
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@ZZ-Cat
Copy link
Contributor Author

ZZ-Cat commented Dec 7, 2025

ERROR: library.properties version value 2025.12.07 is invalid.

Ah. I know what that is. That's the leading zero on the PATCH (IE 07) field in the version tag.
I'll fix that up tomorrow, 'cause it's getting late for me.

@ZZ-Cat
Copy link
Contributor Author

ZZ-Cat commented Dec 7, 2025

@ArduinoBot Pinging you again, as I removed the leading zero in the PATCH field and bumped the version number. Let's see what else you got for me.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

Arduino Lint has suggestions for possible improvements to https://github.com/ZZ-Cat/CRSFforArduino:

Linting library in CRSFforArduino
WARNING: Library name CRSFforArduino contains "Arduino". This is superfluous.                                  
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP014)                                                                                          

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in CRSFforArduino/examples/flight_modes

Linter results for project: no errors or warnings

-------------------

Linting sketch in CRSFforArduino/examples/link_stats

Linter results for project: no errors or warnings

-------------------

Linting sketch in CRSFforArduino/examples/rc_channels

Linter results for project: no errors or warnings

-------------------

Linting sketch in CRSFforArduino/examples/telemetry

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

ERROR: Your submission meets all requirements. However, the pull request could not be merged.

Please follow this guide to resolve a merge conflict:
https://docs.github.com/github/collaborating-with-issues-and-pull-requests/resolving-a-merge-conflict-on-github

Once that is done, it will be merged automatically.

@github-actions github-actions bot requested a review from per1234 December 7, 2025 21:25
@github-actions github-actions bot removed the request for review from per1234 December 7, 2025 21:29
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

Arduino Lint has suggestions for possible improvements to https://github.com/ZZ-Cat/CRSFforArduino:

Linting library in CRSFforArduino
WARNING: Library name CRSFforArduino contains "Arduino". This is superfluous.                                  
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP014)                                                                                          

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in CRSFforArduino/examples/flight_modes

Linter results for project: no errors or warnings

-------------------

Linting sketch in CRSFforArduino/examples/link_stats

Linter results for project: no errors or warnings

-------------------

Linting sketch in CRSFforArduino/examples/rc_channels

Linter results for project: no errors or warnings

-------------------

Linting sketch in CRSFforArduino/examples/telemetry

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions github-actions bot merged commit 7b66c94 into arduino:main Dec 7, 2025
11 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/ZZ-Cat/CRSFforArduino/

github-actions bot pushed a commit that referenced this pull request Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: submission Add library to the list

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant