-
Notifications
You must be signed in to change notification settings - Fork 85
Opta factory test #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Opta factory test #579
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #579 +/- ##
=======================================
Coverage 94.74% 94.74%
=======================================
Files 32 32
Lines 1483 1483
=======================================
Hits 1405 1405
Misses 78 78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Memory usage change @ 7faf9cc
Click for full report table
Click for full report CSV |
|
Memory usage change @ 955f8b6
Click for full report table
Click for full report CSV |
|
Memory usage change @ edb3e51
Click for full report table
Click for full report CSV |
|
Memory usage change @ 0f45f25
Click for full report table
Click for full report CSV |
|
Memory usage change @ db011d8
Click for full report table
Click for full report CSV |
|
Rebase and merge after #577 is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curly braces positioning isn't consistent in file codestyle
| License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
| */ | ||
| #pragma once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add new lines between #pragma includes and class definition
| OptaFactoryTest.begin(); | ||
| OptaFactoryTest.optaIDTest(); | ||
| uint32_t start = millis(); | ||
| while(millis() - start < 2000){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this literal value can become a constant
| digitalWrite(LEDG, LOW); | ||
| digitalWrite(LEDR, HIGH); | ||
| } else { | ||
| if(millis() - lastLedStatusChanged > 250){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this literal value can become a constant
db011d8 to
8030d60
Compare
|
Memory usage change @ 8030d60
Click for full report table
Click for full report CSV |
Changes for factory validation tests in the Provisioning 2.0 Sketch