-
Notifications
You must be signed in to change notification settings - Fork 30
Update packages, add localisation, add search #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Wow this is crazy! I don't have time right this moment to look it over. I will provide more detailed feedback (if any) & testing tomorrow. But, on first glance, I don't think that the Docker files are necessary. The actual website is deployed automatically via Cloudflare Pages, so I don't need that stuff in the repository. Everything else sounds great, though, assuming they work as described! |
|
Haha yep sorry, I know it's a lot! No rush at all. I mainly added Docker for those wishing to self host just to make it easier (I'm running it via that method at https://testube.ediflyer.net), but could have that and the deployment script just in the documentation if preferred. |
|
Here are my observations.
|
|
Thanks @JaxonWright. Just about to go to bed (midnight here) but quick thoughts...
Ah OK I couldn't quite work out what the order was so I made them alphabetical - I only subscribe to a small subset of the services myself so found it easier to find things with an alphabetical sort. It might take a while to sort back but could be done.
I had quite a bit of trouble trying to sort this, can look again but found it quite tricky!
I'd done this on purpose to make use of the otherwise wasted space at the top right of the box. When I first did it there was a lot of dead space at the bottom to the left of the action button - given the limited vertical screen real estate in the Tesla I was trying to make the most of that?
It should probably be Worldwide I guess, but definitely not UK. For licensing reasons the service isn't available in the UK (it's part of the ITV streaming offering here IIRC) - see https://en.wikipedia.org/wiki/BritBox
Perhaps it needs a different name but I'm trying to differentiate between services that are only available in one country vs those available in multiple countries. That's why I also added the 'no filter' option to show all at once.
I don't quite follow? Picking a different region filters the list of services, you can then pick select all/select none to bulk change, and/or click individual ones. You can move between different filter options picking items and then when you hit save they're displayed. I found the easiest way if you only want a few services is to go unfiltered, 'select none', then re-add the ones you want.
Yep agree it could move to the left, I think it's just I had the URL bit open at the time so no space there. Let me know what you think re the above - if with a few tweaks you think it would be good enough to merge I'm happy to try and do so but if too many things don't quite fit for you (it's your project after all!) then just say. |
Sure, it filters the list in the dialog, but I could never get it to apply to the actual data on the page. Yes, I clicked Save. |
…ith deployment to different servers

Apologies @JaxonWright - I know this is a big of a mega PR but I got into a bit of a run yesterday evening!
I've built and deployed it to my own server and it seems to work well on my Model 3 but appreciate needs checking.
Fixes #51 (add localisation)
Fixes #6 (add search)
At a high level these were the main changes made:
.shandchmod +xto run)Worldwide,USorUK- I went through and allocated each one, hopefully correctly! It should be easily extensible for other countries. I also removed the reset option and instead offered select all/select none for each region (as well as an added an unfiltered option to show all services). Switching between regions is possible when selecting services, changes only happen when you hit saveA more detailed Copilot summary is as follows:
This pull request introduces several major improvements to the Angular application's infrastructure, user experience, and dependency management. The most significant changes include the addition of Docker support for building and serving the app with nginx, a comprehensive redesign of the settings dialog with new region and layout preferences, and an upgrade of Angular and related dependencies to version 20. These updates enhance deployment flexibility, user customization, and overall maintainability.
Infrastructure & Deployment
Dockerfilefor building the Angular app and serving it with nginx, including a customnginx.conffor optimized routing, caching, and security headers. (Dockerfile,nginx.conf) [1] [2].dockerignorefile to exclude unnecessary files and directories from Docker builds, improving build performance and security. (.dockerignore)User Experience: Settings Dialog
settings-dialog.component.html,settings-dialog.component.scss) [1] [2] [3]Dependency Management
package.json) [1] [2]Angular Project Configuration
angular.jsonfor more consistent component, directive, and service generation, improving developer experience. (angular.json)Component & Module Enhancements
AppComponentto use a customizable URL from the settings, and added support forMatSelectModulein the app module for the new region selection UI. (app.component.ts,app.module.ts) [1] [2] [3] [4]