fix(container): prevent auto-delete on rapid stop+start (#833) #996
+70
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a container is stopped and immediately restarted, the autoRemove cleanup could race with the restart and delete the container. - Add wait loop in ContainerStart for containers in stopping state - Skip cleanup when bootstrap fails due to sandbox shutting down - Add test for rapid stop+start scenario
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a container is stopped and immediately restarted, the autoRemove cleanup could race with the restart and delete the container.
Type of Change
Motivation and Context
When a container with autoRemove is stopped and immediately restarted, the cleanup task could race with the restart and delete the container unexpectedly. ContainerStart now waits for containers in stopping state before proceeding, and bootstrap failures due to sandbox shutdown no longer trigger container deletion. Includes a test covering the rapid stop+start scenario.
Testing