Skip to content

Fix issue where links became unclickable #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaronbushnell wants to merge 2 commits into
base: a2-build
Choose a base branch
from
Open

Fix issue where links became unclickable #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c56d3c
Fix use of two double quotes
aaronbushnell Aug 19, 2014
8261971
Fix issue where links became unclickable at times fixes #37
aaronbushnell Aug 19, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/main.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
<title>Loading...</title>
<meta name="viewport" content="initial-scale=1.0">
<link rel="shortcut icon" href="/img/favicon.ico"/>
<link rel="alternate" type="application/rss+xml" title="{{i18n "New Posts"}}" href="/feed.xml"/>
<link rel="alternate" type="application/rss+xml" title="{{i18n 'New Posts'}}" href="/feed.xml"/>
</head>
5 changes: 2 additions & 3 deletions client/sass/modules/_comments.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.queue-container{
position:relative;
height:0px;
@include single-transition(ease-out, opacity, 400ms, 0ms);
@include single-transition(ease-out, opacity, 400ms, 0ms);
ul{
position:absolute;
// right:0;
Expand Down Expand Up @@ -59,7 +59,7 @@
// @extend .grid-block;
// display:block;
// padding:3px 8px;

// white-space:nowrap;

// font-size:14px;
Expand Down Expand Up @@ -249,7 +249,6 @@
@include box-sizing(border-box);
@extend .grid-block;
@extend .cf;
float: left;
width: 100%;

.comment-submit{
Expand Down
11 changes: 5 additions & 6 deletions client/sass/modules/_posts.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,18 @@
position: relative;
padding: 25px;
@include box-sizing(border-box);

Copy link

@jakerella jakerella Aug 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry about it for this commit/PR, but generally any kind of "linting" like this should be in it's own commit so that we can clearly see what code was changed versus other things.

.post {
position: relative;
float: left;
width: 100%;
@include cf;

&.animate {
@include single-transition(ease-out, top, 400ms, 0ms);
}

&.inactive {
.post-content,
.post-content,
.post-actions li a {
background-image:url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAYAAACNMs+9AAAAQElEQVQYV2NkIALMnDlTkpGQOpCi9PT053gVwhSBDMOpEFkRToXoirAqxKYIQyEuRSgK8SmCKySkCKyQGEUghQC5OyXvW/4BHwAAAABJRU5ErkJggg==');
}
Expand Down Expand Up @@ -125,7 +124,7 @@
}
&:hover{
color:$a2-red;
}
}
}
.post-domain{
color: #aeaeae;
Expand Down Expand Up @@ -289,7 +288,7 @@
}
.post-actions li a:hover{
background:$highlight-color url("/img/bg-header.png") top center;
}
}
}
.more-button{
position:relative;
Expand Down
Loading