[RFC][Error][ABI] Update Error to enable future compact to cause chaining #396
Conversation
Summary of ChangesHello @tqchen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the error handling Application Binary Interface (ABI) to support more sophisticated error propagation and contextual information. By introducing optional fields for error chaining and arbitrary extra context, it lays the groundwork for richer debugging and error reporting capabilities, all while maintaining compatibility with existing error handling mechanisms. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
mainly for review for now, do not yet merge. |
tqchen
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for error chaining by adding cause_chain and extra_context fields to the Error ABI. The changes are backward-compatible and well-structured. I've identified a critical issue in the implementation of the new FFI function TVMFFIErrorCreateWithCauseAndExtraContext involving an unsafe type cast, which could lead to undefined behavior. I've provided a detailed comment and a code suggestion to rectify this by adding proper type checking and clarifying the handling of null inputs. The rest of the changes, including API definitions and test cases, are sound.
This PR brings a backward compatible update to error ABI to enable possible future support of cause chaining. Specifically, we add two fields: - cause_chain is an optional field for chaining errors - extra_context can be used to optionally attach opaque object (e.g. python error) if needed. The change is backward compatible as we only append to the error field. Most of the existing usages will simply ignore the two fields and use a single error.
3 participants
This PR brings a backward compatible update to error ABI to enable possible future support of cause chaining. Specifically, we add two fields:
The change is backward compatible as we only append to the error field. Most of the existing usages will simply ignore the two fields and use a single error.