MINIFICPP-2700 Log errors if ContentRepository creation failed #2083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaszm
reviewed
Jan 7, 2026
Member
There was a problem hiding this comment.
It may be better to inject a logger as a function parameter instead of creating one locally for a semi-related class.
adamdebreceni
approved these changes
Jan 12, 2026
fgerlits
reviewed
Jan 13, 2026
| /** | ||
| * Create a context repository | ||
| * @param configuration_class_name configuration class name | ||
| * @param fail_safe determines whether or not to make the default class if configuration_class_name is invalid |
Contributor
There was a problem hiding this comment.
the documentation of the fail_safe parameter should be removed (also below, before the createRepository function)
| } | ||
|
|
||
| auto return_obj = core::ClassLoader::getDefaultClassLoader().instantiate<core::ContentRepository>(class_name_lc, | ||
| class_name_lc); |
Contributor
There was a problem hiding this comment.
this indentation looks bad; it may be better to keep this on one line
| return std::make_unique<core::repository::FileSystemRepository>(repo_name); | ||
| } | ||
|
|
||
| logger->log_critical("Could not create the configured content repository ({})", configuration_class_name); |
Contributor
There was a problem hiding this comment.
If we allow logger to be null, then please check it before dereferencing. It may be better to force it to be non-null?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.