HBASE-29787 Run static checks to a Github Action #7566

ndimiduk · 2025-12-19T11:17:46Z

No description provided.

ndimiduk · 2025-12-19T18:11:11Z

I think this is working. Please help me out by double-checking that the checks run by the new system have parity with the jenkins build.

Apache9 · 2025-12-20T09:06:57Z

I think this is working. Please help me out by double-checking that the checks run by the new system have parity with the jenkins build.

Let's just try it on a special branch? Scripts are always hard to review...

Apache9 · 2025-12-20T09:08:52Z

Ah, I saw the checks, let me check the result...

Apache9 · 2025-12-20T09:11:19Z

Seems we missed lots of checks...

+1 overall
Vote	Subsystem	Runtime	Log	Comment
Prechecks
+1	dupname	0m 0s		No case conflicting files found.
+1	@author	0m 0s		The patch does not contain any @author tags.
master Compile Tests
+1	spotless	0m 53s		branch has no errors when running spotless:check.
Patch Compile Tests
+1	codespell	0m 13s		No new issues.
+1	detsecrets	4m 22s		No new issues.
+1	blanks	0m 0s		The patch has no blanks issues.
+1	yamllint	0m 0s		No new issues.
+1	spotless	0m 35s		patch has no errors when running spotless:check.
Other Tests
+1	asflicense	0m 11s		The patch does not generate ASF License warnings.
6m 27s		
Subsystem	Report/Notes
GITHUB PR	https://github.com/apache/hbase/pull/7566
Optional Tests	dupname asflicense codespell detsecrets yamllint spotless
uname	Linux 5359e6d56b16 6.11.0-1018-azure #18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/github/workspace/src/dev-support/hbase-personality.sh
git revision	master / efb501962294022f359c4cba545386ca4c78c7e9
modules	C: . U: .
versions	git=2.34.1 maven=3.9.9 codespell=2.4.1 detsecrets=1.5.0 yamllint=1.35.1
Powered by	Apache Yetus 0.16.0-SNAPSHOT https://yetus.apache.org
This message was automatically generated.

Apache9 · 2025-12-20T09:30:33Z

.github/workflows/yetus-general-check.yml

+            -e GITHUB_SHA="${{ github.sha }}" \
+            -e GITHUB_TOKEN="${{ secrets.GITHUB_TOKEN }}" \
+            -e GITHUB_WORKSPACE=/github/workspace \
+            ghcr.io/apache/yetus:main \


We use yetus 0.14.1 right now, so maybe we should change to 0.14.1?

And we also need to use our own docker file for building HBase?

https://github.com/apache/hbase/blob/master/dev-support/docker/Dockerfile

Yeah, let me look deeper at what our yetus wrapper script does.

The jenkins output says we're using 0.15.0. i'll use that.

github-actions · 2025-12-22T13:53:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 25s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	yamllint	0m 0s		yamllint was not available.
-1 ❌	@author	0m 0s	/results-author.txt	The patch appears to contain 1 @author tags which the community has agreed to not allow in code contributions.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 45s		master passed
+1 💚	compile	9m 22s		master passed
+1 💚	checkstyle	2m 0s		master passed
+1 💚	spotbugs	8m 29s		master passed
+1 💚	spotless	0m 47s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 3s		the patch passed
+1 💚	compile	9m 12s		the patch passed
+1 💚	javac	9m 12s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 59s		the patch passed
+1 💚	spotbugs	8m 38s		the patch passed
+1 💚	hadoopcheck	9m 12s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
-1 ❌	spotless	0m 7s		patch has 34 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
-1 ❌	asflicense	0m 19s	/results-asflicense.txt	The patch generated 1 ASF License warnings.
		64m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: /Dockerfile
GITHUB PR	#7566
Optional Tests	dupname asflicense codespell detsecrets yamllint spotless javac spotbugs checkstyle compile hadoopcheck hbaseanti
uname	Linux 20395ef0f065 6.11.0-1018-azure #18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6339847`
Default Java	Eclipse Adoptium-17.0.11+9
spotless	/patch-spotless.txt
Max. process+thread count	161 (vs. ulimit of 30000)
modules	C: hbase-annotations . U: .
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2025-12-22T14:03:03Z

Forcing some failures, we get

and

Notice that many of the errors are not reported inline.

github-actions · 2025-12-22T15:09:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 8s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	yamllint	0m 0s		yamllint was not available.
-1 ❌	@author	0m 0s	/results-author.txt	The patch appears to contain 1 @author tags which the community has agreed to not allow in code contributions.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 19s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 39s		master passed
+1 💚	compile	9m 36s		master passed
+1 💚	checkstyle	2m 0s		master passed
+1 💚	spotbugs	8m 31s		master passed
+1 💚	spotless	0m 47s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 6s		the patch passed
+1 💚	compile	9m 18s		the patch passed
+1 💚	javac	9m 18s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 55s		the patch passed
+1 💚	spotbugs	8m 31s		the patch passed
+1 💚	hadoopcheck	9m 22s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
-1 ❌	spotless	0m 7s		patch has 34 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
-1 ❌	asflicense	0m 20s	/results-asflicense.txt	The patch generated 1 ASF License warnings.
		64m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: /Dockerfile
GITHUB PR	#7566
Optional Tests	dupname asflicense codespell detsecrets yamllint spotless javac spotbugs checkstyle compile hadoopcheck hbaseanti
uname	Linux fdc02c79623f 6.11.0-1018-azure #18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d230e02`
Default Java	Eclipse Adoptium-17.0.11+9
spotless	/patch-spotless.txt
Max. process+thread count	161 (vs. ulimit of 30000)
modules	C: hbase-annotations . U: .
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

This reverts commit 1475173. This argument is required by the jenkins script

github-actions · 2025-12-22T16:29:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 19s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	yamllint	0m 0s		yamllint was not available.
-1 ❌	@author	0m 0s	/results-author.txt	The patch appears to contain 1 @author tags which the community has agreed to not allow in code contributions.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 33s		master passed
+1 💚	compile	8m 58s		master passed
+1 💚	checkstyle	1m 57s		master passed
+1 💚	spotbugs	8m 13s		master passed
+1 💚	spotless	0m 46s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 1s		the patch passed
+1 💚	compile	9m 4s		the patch passed
+1 💚	javac	9m 4s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 58s		the patch passed
+1 💚	spotbugs	8m 22s		the patch passed
+1 💚	hadoopcheck	9m 11s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
-1 ❌	spotless	0m 7s		patch has 34 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
-1 ❌	asflicense	0m 20s	/results-asflicense.txt	The patch generated 1 ASF License warnings.
		62m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: /Dockerfile
GITHUB PR	#7566
Optional Tests	dupname asflicense codespell detsecrets yamllint spotless javac spotbugs checkstyle compile hadoopcheck hbaseanti
uname	Linux 859e45eb61ec 6.11.0-1018-azure #18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1c8ded4`
Default Java	Eclipse Adoptium-17.0.11+9
spotless	/patch-spotless.txt
Max. process+thread count	161 (vs. ulimit of 30000)
modules	C: hbase-annotations . U: .
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

github-actions · 2025-12-22T17:19:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 9s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	yamllint	0m 0s		yamllint was not available.
-1 ❌	@author	0m 0s	/results-author.txt	The patch appears to contain 1 @author tags which the community has agreed to not allow in code contributions.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 21s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 50s		master passed
+1 💚	compile	8m 57s		master passed
+1 💚	checkstyle	2m 1s		master passed
+1 💚	spotbugs	8m 13s		master passed
+1 💚	spotless	0m 46s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 1s		the patch passed
+1 💚	compile	9m 0s		the patch passed
+1 💚	javac	9m 0s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 56s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	spotbugs	8m 19s		the patch passed
+1 💚	hadoopcheck	9m 15s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
-1 ❌	spotless	0m 7s		patch has 34 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
-1 ❌	asflicense	0m 21s	/results-asflicense.txt	The patch generated 1 ASF License warnings.
		62m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: /Dockerfile
GITHUB PR	#7566
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs spotless yamllint javac spotbugs checkstyle compile hadoopcheck hbaseanti
uname	Linux b6666710f534 6.11.0-1018-azure #18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c43c61b`
Default Java	Eclipse Adoptium-17.0.11+9
spotless	/patch-spotless.txt
Max. process+thread count	160 (vs. ulimit of 30000)
modules	C: hbase-annotations . U: .
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-12-22T19:47:05Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	yamllint	0m 0s		yamllint was not available.
-1 ❌	@author	0m 0s	/results-author.txt	The patch appears to contain 1 @author tags which the community has agreed to not allow in code contributions.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 20s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 22s		master passed
+1 💚	compile	10m 14s		master passed
+1 💚	checkstyle	2m 37s		master passed
+1 💚	spotbugs	9m 13s		master passed
+1 💚	spotless	0m 56s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 12s		the patch passed
+1 💚	compile	10m 43s		the patch passed
+1 💚	javac	10m 43s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	2m 53s		the patch passed
+1 💚	shellcheck	0m 1s		No new issues.
+1 💚	spotbugs	10m 7s		the patch passed
+1 💚	hadoopcheck	14m 7s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
-1 ❌	spotless	0m 11s		patch has 34 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
-1 ❌	asflicense	0m 23s	/results-asflicense.txt	The patch generated 1 ASF License warnings.
		80m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/12/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7566
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs spotless yamllint javac spotbugs checkstyle compile hadoopcheck hbaseanti
uname	Linux 65d5ab161ddb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c43c61b`
Default Java	Eclipse Adoptium-17.0.11+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/12/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	188 (vs. ulimit of 30000)
modules	C: hbase-annotations . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/12/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-12-22T22:43:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 24s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 46s		master passed
+1 💚	compile	1m 37s		master passed
+1 💚	javadoc	1m 37s		master passed
+1 💚	shadedjars	4m 31s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 15s		the patch passed
+1 💚	compile	1m 38s		the patch passed
+1 💚	javac	1m 38s		the patch passed
+1 💚	javadoc	1m 33s		the patch passed
-1 ❌	shadedjars	0m 7s		patch has 10 errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	228m 21s	/patch-unit-root.txt	root in the patch failed.
		255m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/12/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7566
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 7a02603d2b9d 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c43c61b`
Default Java	Eclipse Adoptium-17.0.11+9
shadedjars	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/12/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/12/testReport/
Max. process+thread count	7173 (vs. ulimit of 30000)
modules	C: hbase-annotations . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/12/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

PDavid · 2025-12-23T06:49:26Z

Looks really neat. Thanks for working on this Nick. 👍

This comment has been minimized.

Sign in to view

ndimiduk changed the title ~~HBASE-29787 Move static checks to a Github Action~~ HBASE-29787 Run static checks to a Github Action Dec 19, 2025

This comment has been minimized.

Sign in to view

ndimiduk marked this pull request as ready for review December 19, 2025 18:09

ndimiduk requested review from Apache9, NihalJain, charlesconnell, petersomogyi and stoty December 19, 2025 18:10

Apache9 reviewed Dec 20, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

ndimiduk added 19 commits December 22, 2025 17:15

WIP Experiment with GH Actions for static checks

a1efc7d

pin to a feature branch for dev purposes

8e66126

maybe address yamllint issues

faa7b88

only on PRs for now

d9a977c

add missing statuses:write

0f034f8

drop unsupported paramteres

64d5eee

go "under the hood" to enable personality features

75e6c97

missing env maybe

fa89335

needs write access

69bb2b5

fix yaml lints

84ff0e3

more yaml formatting

ff367b0

use yetus:0.15.0

b46d9be

do as the jenkinsfile does

2cedeea

use the same fetch script as jenkinsfile

ea74e3a

introduce some breakages

3fda221

maybe fix output path for uploads

a186c91

GH won't let us deep-link to artifact results

67b9a73

Revert "GH won't let us deep-link to artifact results"

1586647

This reverts commit 1475173. This argument is required by the jenkins script

BUILD_URL_ARTIFACTS only for actions

c43c61b

ndimiduk force-pushed the 29787-gh-actions-static branch from 1c8ded4 to c43c61b Compare December 22, 2025 16:15

This comment has been minimized.

Sign in to view

HBASE-29787 Run static checks to a Github Action #7566

Are you sure you want to change the base?

HBASE-29787 Run static checks to a Github Action #7566

Conversation

ndimiduk commented Dec 19, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ndimiduk commented Dec 19, 2025

Uh oh!

Apache9 commented Dec 20, 2025

Uh oh!

Apache9 commented Dec 20, 2025

Uh oh!

Apache9 commented Dec 20, 2025

Uh oh!

Apache9 Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

ndimiduk Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

ndimiduk Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 22, 2025

Uh oh!

ndimiduk commented Dec 22, 2025

Uh oh!

This comment has been minimized.

github-actions bot commented Dec 22, 2025

Uh oh!

github-actions bot commented Dec 22, 2025

Uh oh!

github-actions bot commented Dec 22, 2025

Uh oh!

This comment has been minimized.

Apache-HBase commented Dec 22, 2025

Uh oh!

Apache-HBase commented Dec 22, 2025

Uh oh!

PDavid commented Dec 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants