GUACAMOLE-2164: Remove duplicate display resize when changing the font. #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extra display resize is executed too early and can cause errors if the row shift amount is greater than what is still displayed on the screen.
necouchman
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removed
guac_terminal_display_resizeis unnecessary because it is already triggered in__guac_terminal_resize:guacamole-server/src/terminal/terminal.c
Line 1254 in 53ec1f4
This extra display resize is executed too early and can cause errors if the row shift amount is greater than what is still displayed on the screen (when the display is reduced, some lines are are erased and can no longer be copied).