-
Notifications
You must be signed in to change notification settings - Fork 731
GUACAMOLE-925: Add Russian keymap support "ru-ru-qwerty" #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The keymap "ru_ru_qwerty.keymap" has been added to the "src/protocols/rdp/Makefile.am" file to support the Russian keyboard layout.
The file "src/protocols/rdp/keymaps/ru_ru_qwerty.keymap" has been added to support the Russian keyboard layout.
| map +caps -shift 0x2C..0x35 ~ "ЯЧСМИТЬБЮ," | ||
|
|
||
| map +caps +shift 0x29 0x02..0x0D ~ "ё!"№;%:?*()_+" | ||
| map +caps +shift 0x10..0x1B 0x2B ~ "йцукенгшщзхъ/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This (and other lines) duplicates the same scancodes and modifier combination as a previous line:
map +caps +shift 0x10..0x1B 0x2B ~ "qwertyuiop{}|"
There needs to be something that distinguishes the context of typing these characters for the mapping to work correctly. For example, if the user presses "q" or "й", this map will result in the same sequence of scancodes being sent, but that sequence will not necessarily be interpreted to produce "q" (or "й"). Proper behavior will depend on some sort of additional state that Guacamole isn't aware of, and the intent of the user may not match what ultimately ends up typed.
Is there something else that needs to be supported by these keymaps for this to be unambiguous? Does the Russian keyboard have additional modifier keys or state that needs to be represented?
Привет. Помоги пожалуйста решить эту проблему с РУ расскладкой. Напиши мне плиз в ТГ @truffle_tg |
Привет! Можете взять измененные файлы или целиком ветку VAGurko:GUACAMOLE-925: |
К сожалению я только знакомлюсь с docker и ubuntu и плохо в этом разбираюсь В секции volumes сервиса guacd:volumes:
Верно мыслю? networkscreate a network 'guacnetwork_compose' in mode 'bridged'networks: servicesservices: guacdguacd: postgrespostgres: guacamoleguacamole: ########### optional ############## nginxnginx: |
|
Не уверен что получится все корректно смаппить, там собирается новый образ для докера в который добавляются измененные файлы и возможно они будут находиться во временной директории каждый запуск в новом каталоге. |
|
@VAGurko Just a reminder that you have requested changes/comments on this from Mike... |
могу попросить тебя собрать образы в dockerhub с новой версией 1.6 где будет твое исправление с раскладкой? |
The official images will be released to Dockerhub when the version that contains this commit is released. |
|
I plan to make new changes after the New Year for the 1.6.0 release. |
|
@VAGurko привет. я вчера весь день потратил чтобы не имея знаний о докерах, с помощью ИИ вроде собрал сборку 1.6 с твоими исправлениями. Но как я понимаю это не решило проблемы с горячими клавишами. моя сборка |
Возможно в версии 1.6.0 что-то поменялось. |
The keymap "ru_ru_qwerty.keymap" has been added to the "src/protocols/rdp/Makefile.am" file to support the Russian keyboard layout.
The file "src/protocols/rdp/keymaps/ru_ru_qwerty.keymap" has been added to support the Russian keyboard layout.