-
Notifications
You must be signed in to change notification settings - Fork 731
GUACAMOLE-1961: improve terminal selection #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
necouchman
merged 7 commits into
apache:main
from
corentin-soriano:GUACAMOLE-1961_improve_selection
Nov 5, 2025
Merged
GUACAMOLE-1961: improve terminal selection #556
necouchman
merged 7 commits into
apache:main
from
corentin-soriano:GUACAMOLE-1961_improve_selection
Nov 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
880d8b1 to
891875d
Compare
891875d to
fe1b57f
Compare
fe1b57f to
4f579a2
Compare
4f579a2 to
4de033d
Compare
4de033d to
dcbb090
Compare
Contributor
|
@corentin-soriano Looks like some conflicts after I merged that other PR for GUACAMOLE-1943. |
dcbb090 to
b6c28d6
Compare
Member
Author
Fixed! |
necouchman
requested changes
Nov 3, 2025
Contributor
necouchman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things - no major concerns, just minor questions.
…ck with words or lines.
b6c28d6 to
fc7bee4
Compare
necouchman
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements described in GUACAMOLE-1961.