Skip to content

Update CDVWKInAppBrowser.m #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jainsuneet wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −6
Open

Update CDVWKInAppBrowser.m #1069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions src/ios/CDVWKInAppBrowser.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,13 +303,22 @@ - (void)openInCordovaWebView:(NSURL*)url withOptions:(NSString*)options
[self.webViewEngine loadRequest:request];
}

- (void)openInSystem:(NSURL*)url
- (void)openInSystem:(NSURL *)url
{
[[UIApplication sharedApplication] openURL:url options:@{} completionHandler:^(BOOL success) {
if (!success) {
[[NSNotificationCenter defaultCenter] postNotification:[NSNotification notificationWithName:CDVPluginHandleOpenURLNotification object:url]];
}
}];
// Check if the URL can be opened
if ([[UIApplication sharedApplication] canOpenURL:url]) {

// Use the new method to open the URL with completion handler
[[UIApplication sharedApplication] openURL:url options:@{} completionHandler:^(BOOL success) {
if (!success) {
// Post a notification if the URL could not be opened
[[NSNotificationCenter defaultCenter] postNotification:[NSNotification notificationWithName:CDVPluginHandleOpenURLNotification object:url]];
}
}];
} else {
// Post a notification if the URL can't be opened
[[NSNotificationCenter defaultCenter] postNotification:[NSNotification notificationWithName:CDVPluginHandleOpenURLNotification object:url]];
}
}

- (void)loadAfterBeforeload:(CDVInvokedUrlCommand*)command
Expand Down