Skip to content

Conversation

@erisu
Copy link
Member

@erisu erisu commented Jun 24, 2025

Platforms affected

Android

Motivation and Context

Cleanup Code

Description

  • use lambda functions
  • remove redundant casting and types
  • doctype fix
  • use switch case
  • use .isEmpty() instead of .length()==0
  • remove unused import

Testing

npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu
Copy link
Member Author

erisu commented Jul 13, 2025

Last call for reviews.

@erisu erisu force-pushed the refactor/cleanup-code branch from cc2769f to 6f0229d Compare July 14, 2025 13:18
@erisu erisu merged commit 1ece88e into apache:master Jul 14, 2025
24 of 26 checks passed
@erisu erisu deleted the refactor/cleanup-code branch July 14, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants