Reducing the complexity of the fillStatement method #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking the fillStatement method on line 303 with SonarQube showed CodeSmell, it seems that it considered a high complexity. I made these changes by fragmenting this method into smaller ones, to reduce complexity
Member
garydgregory
left a comment
garydgregory
left a comment
There was a problem hiding this comment.
-1: I don't see how this is better than what we have now. It might even make or worse 🤔
Author
|
Ok, I was doing this quality analysis on the project and noticed this point that SonarQube complained about. Thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking the fillStatement method on line 303 with SonarQube showed CodeSmell, it seems that it considered a high complexity. I made these changes by fragmenting this method into smaller ones, to reduce complexity