-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add Guest OS mapping for windows server 2025 on VMware #12358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12358 +/- ##
=========================================
Coverage 17.60% 17.60%
- Complexity 15668 15669 +1
=========================================
Files 5915 5915
Lines 529967 529967
Branches 64734 64734
=========================================
Hits 93304 93304
+ Misses 426195 426194 -1
- Partials 10468 10469 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
@blueorangutan package |
|
@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16233 |
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm, but should this not go on earlier versions than 23?
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
shwstppr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| UPDATE `cloud`.`configuration` SET value='firstfit' WHERE name IN ('vm.allocation.algorithm', 'volume.allocation.algorithm') AND value='userconcentratedpod_firstfit'; | ||
|
|
||
| -- Add Windows Server 2025 guest OS and mappings | ||
| CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (6, 'Windows Server 2025 (64-bit)', 'VMware', '7.0', 'windows2022srvNext_64Guest'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point we should stop using constant category IDs as they are dynamic now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
today is a good day to die… ;)
weizhouapache
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
this is a minor guest os support, can we move to schema-42200to42210.sql ?



Description
This PR adds guest os and mappings for Windows Server 2025
Addresses: #12324
Deployed a new virtual machine on vmware 8.0.3 and set the guest os to Windows server 2025 and found the mapping
on ESXi host - the guest os it guest mapped to is

windows2022srvNext_64GuestTypes of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
VM OS Type

ISO registered with OS type Windows Server 2025:

How did you try to break this feature and the system with this change?