import network acl rules using csv #12013

sudo87 · 2025-11-07T04:38:05Z

Description

This PR fixes #8858

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

Screen.Recording.2025-11-12.at.5.32.34.PM.mov

How Has This Been Tested?

Test file:
AclRules-test-acls-e27d1e32-09b6-4cb9-acde-2a748d857678.csv

How did you try to break this feature and the system with this change?

codecov · 2025-11-07T04:46:48Z

Codecov Report

❌ Patch coverage is 0% with 130 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.58%. Comparing base (55ab7c5) to head (e251cec).
⚠️ Report is 5 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...a/com/cloud/network/vpc/NetworkACLServiceImpl.java	0.00%	71 Missing ⚠️
.../api/command/user/network/ImportNetworkACLCmd.java	0.00%	38 Missing ⚠️
.../api/command/user/network/CreateNetworkACLCmd.java	0.00%	20 Missing ⚠️
...in/java/com/cloud/server/ManagementServerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #12013      +/-   ##
============================================
- Coverage     17.59%   17.58%   -0.01%     
  Complexity    15595    15595              
============================================
  Files          5910     5912       +2     
  Lines        529606   529844     +238     
  Branches      64705    64741      +36     
============================================
  Hits          93178    93178              
- Misses       425940   426178     +238     
  Partials      10488    10488

Flag	Coverage Δ
uitests	`3.56% <ø> (-0.02%)`	⬇️
unittests	`18.65% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sudo87 · 2025-11-10T11:50:46Z

@blueorangutan package

blueorangutan · 2025-11-10T11:52:03Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland

clgtm so far, let me test when you are ready @sudo87

blueorangutan · 2025-11-10T13:24:37Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15706

DaanHoogland · 2025-11-12T13:45:18Z

@blueorangutan test keepEnv

blueorangutan · 2025-11-12T13:48:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

sudo87 · 2025-11-13T04:22:04Z

@blueorangutan package

blueorangutan · 2025-11-13T04:24:04Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-11-13T05:48:06Z

[SF] Trillian test result (tid-14811)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54425 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12013-t14811-kvm-ol8.zip
Smoke tests completed. 147 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_ssl_offloading_isolated_network	`Failure`	323.17	test_ssl_offloading.py
test_01_redundant_vpc_site2site_vpn	`Failure`	419.80	test_vpc_vpn.py

blueorangutan · 2025-11-13T06:05:09Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15736

blueorangutan · 2025-11-26T00:22:03Z

[SF] Trillian test result (tid-14868)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 52382 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12013-t14868-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland · 2025-12-01T13:50:52Z

server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java

+        // no rules got imported
+        if (createdRules.isEmpty() && !errors.isEmpty()) {
+            logger.error("Failed to import any ACL rules. Errors: {}", String.join("; ", errors));
+            throw new CloudRuntimeException("Failed to import any ACL rules.");


this is very confusing to a user. the reason is probably because a rule already existed and it is counterintuitive to not allow it. We might add a flag allowing overwriting it.

As per the discussion on original issue, user can create new ACL and import the csv and assign it to network. Allowing overwriting rules will lead to loss of simplicity.

DaanHoogland · 2025-12-01T13:51:38Z

this is very confusing to a user. the reason is probably because a rule already existed and it is counterintuitive to not allow it. We might add a flag allowing overwriting it.
tested and works as expected otherwise.

api/src/main/java/org/apache/cloudstack/api/command/user/network/ImportNetworkACLCmd.java

blueorangutan · 2025-12-10T08:18:04Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-12-10T09:33:58Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15973

sudo87 · 2025-12-10T10:39:52Z

@blueorangutan test

blueorangutan · 2025-12-10T10:42:05Z

@sudo87 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

api/src/main/java/org/apache/cloudstack/api/command/user/network/ImportNetworkACLCmd.java

sureshanaparti

minor suggestions, clgtm

sudo87 · 2025-12-10T12:02:01Z

Thank you @sureshanaparti for your review comments.

blueorangutan · 2025-12-11T02:45:26Z

[SF] Trillian test result (tid-14957)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54625 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12013-t14957-kvm-ol8.zip
Smoke tests completed. 144 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_updating_nics_on_two_shared_networks	`Error`	2.74	test_gateway_on_shared_networks.py
ContextSuite context=TestGatewayOnSharedNetwork>:teardown	`Error`	4.97	test_gateway_on_shared_networks.py
test_uservm_host_control_state	`Failure`	17.04	test_host_control_state.py
ContextSuite context=TestHostControlState>:teardown	`Error`	32.71	test_host_control_state.py
test_01_primary_storage_nfs	`Error`	0.21	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.34	test_primary_storage.py
test_01_primary_storage_scope_change	`Error`	0.13	test_primary_storage_scope.py
test_02_unsecure_vm_migration	`Error`	786.42	test_vm_life_cycle.py

blueorangutan · 2025-12-12T01:23:33Z

[SF] Trillian test result (tid-14966)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 58833 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12013-t14966-kvm-ol8.zip
Smoke tests completed. 137 look OK, 12 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_DeployVmAntiAffinityGroup_in_project	`Error`	72.87	test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup	`Error`	25.89	test_affinity_groups.py
test_01_condensed_drs_algorithm	`Error`	18.68	test_cluster_drs.py
test_02_balanced_drs_algorithm	`Error`	19.63	test_cluster_drs.py
ContextSuite context=TestClusterDRS>:teardown	`Error`	20.68	test_cluster_drs.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	`Failure`	49.42	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	`Failure`	50.40	test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	`Failure`	49.53	test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	`Failure`	98.40	test_internal_lb.py
test_03_create_vpc_domain_vpc_offering	`Error`	54.95	test_domain_vpc_offerings.py
test_uservm_host_control_state	`Failure`	16.83	test_host_control_state.py
ContextSuite context=TestHostControlState>:teardown	`Error`	35.32	test_host_control_state.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	35.85	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	110.22	test_kubernetes_clusters.py
test_12_test_deploy_cluster_different_offerings_per_node_type	`Failure`	96.08	test_kubernetes_clusters.py
test_01_non_strict_host_anti_affinity	`Failure`	74.04	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	36.27	test_nonstrict_affinity_group.py
test_02_L2_persistent_network	`Failure`	1.80	test_persistent_network.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist	`Failure`	22.30	test_persistent_network.py
test_02_vpc_privategw_static_routes	`Failure`	97.27	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	93.13	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	101.16	test_privategw_acl.py
test_03_create_vpc_with_specified_source_nat_ip_address	`Error`	52.04	test_set_sourcenat.py
test_04_change_source_nat_ip_address_for_vpc	`Error`	102.81	test_set_sourcenat.py
test_01_vpn_usage	`Error`	1.07	test_usage.py

github-actions · 2025-12-22T13:28:29Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

sudo87 · 2025-12-31T05:41:36Z

@blueorangutan package

blueorangutan · 2025-12-31T05:42:04Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-12-31T06:47:21Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 16216

sudo87 · 2025-12-31T07:11:04Z

@blueorangutan test

blueorangutan · 2025-12-31T07:12:05Z

@sudo87 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

sudo87 · 2026-01-06T04:17:15Z

@blueorangutan test

blueorangutan · 2026-01-06T04:18:04Z

@sudo87 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

import network acl rules using csv

2b7dc78

boring-cyborg bot added component:api component:networking component:vpc labels Nov 7, 2025

Parse csv in UI, prepare payload for import

63cde64

boring-cyborg bot added the component:UI label Nov 10, 2025

DaanHoogland added the status:needs-testing label Nov 10, 2025

DaanHoogland approved these changes Nov 10, 2025

View reviewed changes

fix issues during testing

df0b890

boring-cyborg bot added the component:management-server label Nov 12, 2025

sudo87 marked this pull request as ready for review November 12, 2025 12:05

sudo87 requested a review from DaanHoogland November 12, 2025 12:07

DaanHoogland reviewed Dec 1, 2025

View reviewed changes

sureshanaparti requested a review from Copilot December 5, 2025 09:13

Copilot started reviewing on behalf of sureshanaparti December 5, 2025 09:14 View session

sureshanaparti reviewed Dec 5, 2025

View reviewed changes