-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Change internal ID to UUID in user disable event #11824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change internal ID to UUID in user disable event #11824
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11824 +/- ##
============================================
+ Coverage 17.42% 17.56% +0.13%
- Complexity 15336 15498 +162
============================================
Files 5892 5899 +7
Lines 526521 527793 +1272
Branches 64293 64479 +186
============================================
+ Hits 91767 92703 +936
- Misses 424401 424666 +265
- Partials 10353 10424 +71
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
vishesh92
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm. didn't test.
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
api/src/main/java/org/apache/cloudstack/api/command/admin/user/DisableUserCmd.java
Show resolved
Hide resolved
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15432 |
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-14701)
|
bernardodemarco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Description
During the user disablement process, created events contain the user internal ID instead of the user UUID. Therefore, this PR fixes this behaviour by changing the internal ID in the event descriptions to the user's UUID.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
I built the packages with the changes and applied them to my local environment. In Apache CloudStack, I created a new user
userin theadminaccount, then disabled it. In the events, I validated that the user's UUID were shown instead of the user's internal ID.How did you try to break this feature and the system with this change?