Skip to content

Conversation

@iishitahere
Copy link

This PR implements enhancements related to traffic shaping and VMware network configurations:

NetUtilsTest: Improved handling of default NIC IPs to ensure compatibility with both IPv4 and IPv6 formats for traffic shaping configurations.
ScriptTest: Updated command execution handling to ensure better compatibility with VMware's network setup, improving timeout management and process error handling.
ProcessTest: Addressed potential race conditions in process execution, enhancing stability during network traffic shaping tests on VMware environments.

@sureshanaparti
Copy link
Contributor

@blueorangutan package

@sureshanaparti sureshanaparti added this to the 4.21.0 milestone Jun 5, 2025
@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13618

@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (546ef31) to head (6d327d5).
⚠️ Report is 888 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main   #10162       +/-   ##
=============================================
- Coverage     15.80%        0   -15.81%     
=============================================
  Files          5627        0     -5627     
  Lines        492363        0   -492363     
  Branches      59696        0    -59696     
=============================================
- Hits          77828        0    -77828     
+ Misses       406012        0   -406012     
+ Partials       8523        0     -8523     
Flag Coverage Δ
uitests ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13669

ProcessResult result = RUNNER.executeCommands(Arrays.asList("sleep", "0"));
// Replace "sleep" with the cross-platform "timeout" command
ProcessResult result = RUNNER.executeCommands(Arrays.asList("timeout", "/t", "1"));
Assert.assertEquals(result.getReturnCode(), 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iishitahere , this test fails at this assert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

6 participants