CASSANDRA-21092: Add --disable-zero-copy-streaming parameter to allow loading 3.x sstables (trunk) #4543
+263
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bles Legacy Cassandra 3.x sstables are incompatible with zero-copy streaming in Cassandra 5.0+. This adds a --disable-zero-copy-streaming flag to sstableloader that disables zero-copy streaming when loading legacy sstables. This patch implements the flag in LoaderOptions and BulkLoader, and adds tests to verify that loading legacy 3.11 sstables fails with zero-copy enabled and succeeds with zero-copy disabled. patch by Paulo Motta; reviewed by XXXX for CASSANDRA-21092
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy Cassandra 3.x sstables are incompatible with zero-copy streaming in Cassandra 5.0+. This adds a --disable-zero-copy-streaming flag to sstableloader that disables zero-copy streaming when loading legacy sstables.
This patch implements the flag in LoaderOptions and BulkLoader, and adds tests to verify that loading legacy 3.11 sstables fails with zero-copy enabled and succeeds with zero-copy disabled.