[AURON #1637] Enforce Clippy lint and Eliminate unwrap #1649
+951
−693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @richox |
yew1eb
changed the title
yew1eb
force-pushed
the
add_clippy_lint
branch
2 times, most recently
from
7bee180 to
cd9dd8e
Compare
yew1eb
changed the title
Contributor
|
we can use |
yew1eb
force-pushed
the
add_clippy_lint
branch
2 times, most recently
from
b589ad1 to
fdfe215
Compare
yew1eb
force-pushed
the
add_clippy_lint
branch
from
fdfe215 to
efa87e3
Compare
yew1eb
changed the title
Contributor
Author
|
@richox all unwraps are removed (including tests). Rust tests and Clippy passed. Please take a look, CI currently denies unwrap_used; once that's done, we'll switch to |
Contributor
Author
|
@richox CI Green, PTAL. |
Contributor
Author
|
@richox could you please take a look? |
richox
reviewed
Dec 1, 2025
native-engine/auron/src/alloc.rs
Outdated
|
|
||
| fn update(&self) { | ||
| let _lock = self.mutex.lock().unwrap(); | ||
| let _lock = self.mutex.lock().expect("lock"); |
Contributor
There was a problem hiding this comment.
we replace this with parking_lot::Mutex, it has a unwrap-free lock API
Contributor
Author
|
@richox I’ve addressed all your comments and updated the PR. PTAL. |
Contributor
Author
|
@richox PTAL when you get a moment. Thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1637 .
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
How was this patch tested?