refactor(aria/listbox): avoid circular references at runtime #32488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
listbox-circular-deps-poc
branch
from
fd6273b to
0cf9339
Compare
wagnermaciel
reviewed
Dec 5, 2025
|
|
||
| import {booleanAttribute, computed, Directive, ElementRef, inject, input} from '@angular/core'; | ||
| import {_IdGenerator} from '@angular/cdk/a11y'; | ||
| import {OptionPattern} from '../private'; |
Contributor
There was a problem hiding this comment.
Should we use '@angular/aria/private'; or does that have no impact?
Member
Author
There was a problem hiding this comment.
Imports within the same npm package need to be relative after the recent dev infra changes.
Contributor
There was a problem hiding this comment.
Should we change listbox.ts to use the relative path then?
Member
Author
There was a problem hiding this comment.
Ah yeah we should. Not sure why the build didn't break.
wagnermaciel
approved these changes
Dec 5, 2025
crisbeto
force-pushed
the
listbox-circular-deps-poc
branch
from
0cf9339 to
a35fe19
Compare
crisbeto
added
action: merge
Reworks the Aria listbox to avoid a circular dependency between `Listbox` and `Option`.
crisbeto
force-pushed
the
listbox-circular-deps-poc
branch
from
a35fe19 to
826430b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the Aria listbox to avoid a circular dependency between
ListboxandOption.